Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-66133

Comment thread objects (MBDiscussion, MBThread and root MBMessage) are created during asset creation, but that it is not necessary as CommentManager also handle it

Details

    Description

      In LPS-2864 was added some logic in order to create all comment thread structure during asset creation (MBDiscussion, MBThread and root MBMessage objects) but that it is not necessary as CommentManager also handle it during comment creation.

      After some testing we have detected that all MBThread entries causes an overhead in the system, for example:

      • During staging reindex operation, a 30% of improvement is obtained deactivating deleting all those objects, and comment functionality is not affected.
      • During full reindex operation, some customers have reported that 25%-50% of the time is spent during MBThread reindex

      In order to improve throughput, we should:

      1. Remove all comment creation logic from assets creation (JournalArticleLocalServiceImpl.addArticle, BlogsEntryLocalServiceImpl.addEntry, Layout, ....)
      2. Clean all unused objects during upgrade to 7.0

      Attachments

        Issue Links

          Activity

            People

              melody.wu Melody Wu
              jorge.diaz Jorge Diaz
              Kiyoshi Lee Kiyoshi Lee
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                6 years, 45 weeks, 5 days ago

                Packages

                  Version Package
                  7.0.0 DXP FP3
                  7.0.0 DXP SP1
                  Master