Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Comment thread objects (MBDiscussion, MBThread and root MBMessage) are created during asset creation, but that it is not necessary as CommentManager also handle it

Description

In was added some logic in order to create all comment thread structure during asset creation (MBDiscussion, MBThread and root MBMessage objects) but that it is not necessary as CommentManager also handle it during comment creation.

After some testing we have detected that all MBThread entries causes an overhead in the system, for example:

  • During staging reindex operation, a 30% of improvement is obtained deactivating deleting all those objects, and comment functionality is not affected.

  • During full reindex operation, some customers have reported that 25%-50% of the time is spent during MBThread reindex

In order to improve throughput, we should:

  1. Remove all comment creation logic from assets creation (JournalArticleLocalServiceImpl.addArticle, BlogsEntryLocalServiceImpl.addEntry, Layout, ....)

  2. Clean all unused objects during upgrade to 7.0

Activity

Show:

Sergio Gonzalez July 29, 2016 at 12:27 AM

Just started reviewing

 

Sent from GH

Adolfo Pérez Álvarez July 4, 2016 at 1:48 AM

Just started reviewing

 

Sent from GH

Adolfo Pérez Álvarez June 9, 2016 at 7:44 AM

Marking as "impediment", as it cannot be done before the release.

Sergio Gonzalez June 9, 2016 at 6:17 AM

Adolfo Pérez Álvarez June 1, 2016 at 3:24 AM

Lowering priority, as this is more a performance issue when reindexing than a loss of functionality.

Fixed

Details

Assignee

Reporter

Labels

Branch Version/s

7.0.x

Backported to Branch

Committed

Fix Priority

3

Git Pull Request

7.0 Fix Pack Version

3

Story Points

Components

Fix versions

Affects versions

Priority

Zendesk Support

Created May 26, 2016 at 9:43 AM
Updated June 25, 2023 at 11:24 PM
Resolved September 1, 2016 at 2:42 PM
Loading...