As a developer, I would like the Gradle "buildService" task to always fail if the Service Builder has any kind of error

• Type: Story
• Status: Closed
• Priority: Minor
• Resolution: Completed
• Affects Version/s: None
• Fix Version/s: 7.0.0 DXP FP3, 7.0.0 DXP SP2, 7.1.X, Master
• Component/s: Core Infrastructure, Core Infrastructure > Service Builder
• Labels:
  • liferay-digital-enterprise-70-sp1
  • liferay-fixpack-de-3-7010
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed

Some kind of errors thrown by Service Builder are simply logged and do not fail the build. For example, if a Gradle project does not have the group property defined and the project name includes a dash, the following error is printed in the console, but the build completes successfully:

C:\Users\distr\AppData\Local\Temp\ServiceBuilder.temp:1:16: expecting SEMI, found '-'
        at antlr.Parser.match(Parser.java:211)
        at de.hunsicker.jalopy.language.antlr.InternalJavaParser.packageDefinition(InternalJavaParser.java:367)
        at de.hunsicker.jalopy.language.antlr.InternalJavaParser.parse(InternalJavaParser.java:269)
        at de.hunsicker.jalopy.language.JavaRecognizer.parse(JavaRecognizer.java:588)
        at de.hunsicker.jalopy.Jalopy.parse(Jalopy.java:1212)
        at de.hunsicker.jalopy.Jalopy.format(Jalopy.java:1044)
        at de.hunsicker.jalopy.Jalopy.format(Jalopy.java:1017)
        at com.liferay.portal.tools.ToolsUtil.writeFile(ToolsUtil.java:443)
        at com.liferay.portal.tools.ToolsUtil.writeFile(ToolsUtil.java:481)
        at com.liferay.portal.tools.ToolsUtil.writeFile(ToolsUtil.java:355)
        at com.liferay.portal.tools.service.builder.ServiceBuilder._createServicePropsUtil(ServiceBuilder.java:3148)
        at com.liferay.portal.tools.service.builder.ServiceBuilder.<init>(ServiceBuilder.java:797)
        at com.liferay.portal.tools.service.builder.ServiceBuilder.main(ServiceBuilder.java:219)
C:\Users\distr\AppData\Local\Temp\ServiceBuilder.temp:3:1: expecting EOF, found 'import'
        at antlr.Parser.match(Parser.java:211)
        at de.hunsicker.jalopy.language.antlr.InternalJavaParser.parse(InternalJavaParser.java:308)
        at de.hunsicker.jalopy.language.JavaRecognizer.parse(JavaRecognizer.java:588)
        at de.hunsicker.jalopy.Jalopy.parse(Jalopy.java:1212)
        at de.hunsicker.jalopy.Jalopy.format(Jalopy.java:1044)
        at de.hunsicker.jalopy.Jalopy.format(Jalopy.java:1017)
        at com.liferay.portal.tools.ToolsUtil.writeFile(ToolsUtil.java:443)
        at com.liferay.portal.tools.ToolsUtil.writeFile(ToolsUtil.java:481)
        at com.liferay.portal.tools.ToolsUtil.writeFile(ToolsUtil.java:355)
        at com.liferay.portal.tools.service.builder.ServiceBuilder._createServicePropsUtil(ServiceBuilder.java:3148)
        at com.liferay.portal.tools.service.builder.ServiceBuilder.<init>(ServiceBuilder.java:797)
        at com.liferay.portal.tools.service.builder.ServiceBuilder.main(ServiceBuilder.java:219)
13:57:24,274 ERROR [io:1071] UNKNOWN_ERROR
expecting EOF, found 'import'
Nested Exception is: C:\Users\distr\AppData\Local\Temp\ServiceBuilder.temp:3:1: expecting EOF, found 'import'
        at antlr.Parser.match(Parser.java:211)
        at de.hunsicker.jalopy.language.antlr.InternalJavaParser.parse(InternalJavaParser.java:308)
        at de.hunsicker.jalopy.language.JavaRecognizer.parse(JavaRecognizer.java:588)
        at de.hunsicker.jalopy.Jalopy.parse(Jalopy.java:1212)
        at de.hunsicker.jalopy.Jalopy.format(Jalopy.java:1044)
        at de.hunsicker.jalopy.Jalopy.format(Jalopy.java:1017)
        at com.liferay.portal.tools.ToolsUtil.writeFile(ToolsUtil.java:443)
        at com.liferay.portal.tools.ToolsUtil.writeFile(ToolsUtil.java:481)
        at com.liferay.portal.tools.ToolsUtil.writeFile(ToolsUtil.java:355)
        at com.liferay.portal.tools.service.builder.ServiceBuilder._createServicePropsUtil(ServiceBuilder.java:3148)
        at com.liferay.portal.tools.service.builder.ServiceBuilder.<init>(ServiceBuilder.java:797)
        at com.liferay.portal.tools.service.builder.ServiceBuilder.main(ServiceBuilder.java:219)