Poor Performance in BaseUpgradePortletId.upgradeResourcePermission

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.2.X EE, 7.0.0 DXP SP2, Master
• Fix Version/s: 7.0.0 DXP FP22, 7.0.0 DXP SP4, 7.0.X EE, 7.0.4 CE GA5, 7.1.X, Master
• Component/s: Core Infrastructure, Core Infrastructure > Upgrade Framework, Performance
• Labels:
  • liferay-digital-enterprise-70-sp4
  • liferay-fixpack-de-22-7010
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed
• Story Points: 1.5
• Fix Priority: 2
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/46152

Description
The BaseUpgradePortletId.upgradeResourcePermission process is inefficient. This is bad because this method gets called a lot during an upgrade to Liferay 7.

Steps to Reproduce

1. Start up a fresh instance of Liferay 6.2 and log in as the admin user.
2. Navigate to Control Panel > Configuration > Server Administration > Script
3. Change the Language to Groovy and paste the contents of the attached addManyRolesAndMediaGalleryPermissions.groovy script into the Script box.
4. Press the Execute button. This will cause a Media Gallery portlet to be added to the home page, and 500000 new roles to be created, each with their own resource permission for the Media Gallery portlet (Note: This script will take about 7 hours to complete).
5. Shut down Liferay.
6. Run the upgrade process to the version you are testing on on your database. Observe the length of time it takes to complete UpgradeImageGallery.

Expected Result: UpgradeImageGallery completes fairly quickly
Actual Result: UpgradeImageGallery takes a long time to complete