Poor performance in DLServiceVerifyProcess.updateFolderAssets when there are a large number of DLFolders without Assets

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.2.X EE, 7.0.X EE, Master
• Fix Version/s: 6.2.X EE, 7.0.0 DXP FP14, 7.0.0 DXP SP3, 7.0.3 CE GA4, 7.0.X EE, 7.1.X, Master
• Component/s: DM > Upgrade, Documents & Media, Performance
• Labels:
  • 62-ee-sp19
  • liferay-digital-enterprise-70-sp3
  • liferay-fixpack-de-14-7010
  • liferay-fixpack-portal-146-6210
• Branch Version/s:
  7.0.x, 6.2.x
• Backported to Branch:
  Committed
• Story Points: 1
• Fix Priority: 3
• Sprint: Collab 2
• Git Pull Request: https://github.com/adolfopa/liferay-portal/pull/493

The DLServiceVerifyProcess.updateFolderAssets method attempts to fetch every DLFolder without a corresponding entry in the AssetEntry table into a list, and then perform some operations on them. For users with large databases upgrading from 6.1, this can cause performance problems and potentially an OutOfMemory error as it tries to create a List of potentially millions of DLFolders. We should use an ActionableDynamicQuery instead.