SAML DXP keep-alive module is broken

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X EE
• Fix Version/s: 7.0.X EE, Master
• Component/s: Application Security > SAML
• Labels:
  • liferay-saml-2.0-provider-3.1.0
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 4
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal-ee/pull/16751
• Bug Type: Security

There are missing taglib declarations in JSPs.

Steps to reproduce:

1. Deploy saml-addon-keep-alive-hook (if present) and saml-addon-keep-alive-web from ee-7.0.x liferay-portal-ee branch
2. Go to SAML admin, configure as IdP
3. Display IdP configuration tab

Expected result: Edit form contains Keep Alive section
Actual result: no section is displayed

Steps to verify it's working

1. Deploy saml-addon-keep-alive-web from ee-7.0.x liferay-portal-ee branch
2. Configure first portal as IdP
3. Configure second portal as SP, Set Keep Alive URL: http://...IdPServer.../c/portal/saml/keep_alive
4. Configure third portal as SP, Set Keep Alive URL: http://...IdPServer.../c/portal/saml/keep_alive
5. Configure IdP server with both SPs, Set Keep Alive URL: http://...TheSPServer.../c/portal/saml/keep_alive
6. Sign out everywhere
7. Sign in everywhere again
8. Go to any SP
9. Open browser dev tools, network tab
10. Refresh SP page and verify there is request to http://...IdPServer.../c/portal/saml/keep_alive?entityId=... and that response contains two document.write commands similar to

    document.write('<img alt="" src="http\x26\x23x3a\x3b\x26\x23x2f\x3b\x26\x23x2f\x3balpha\x26\x23x2e\x3bcz\x26\x23x3a\x3b18080\x26\x23x2f\x3bc\x26\x23x2f\x3bportal\x26\x23x2f\x3bsaml\x26\x23x2f\x3bkeep_alive\x26\x23x3f\x3br\x26\x23x3d\x3bHXDxMDB3"/>');
    document.write('<img alt="" src="http\x26\x23x3a\x3b\x26\x23x2f\x3b\x26\x23x2f\x3bbeta\x26\x23x2e\x3bcz\x26\x23x3a\x3b28080\x26\x23x2f\x3bc\x26\x23x2f\x3bportal\x26\x23x2f\x3bsaml\x26\x23x2f\x3bkeep_alive\x26\x23x3f\x3br\x26\x23x3d\x3bHXDxMDB3"/>');