Service Builder generates wrong integration tests if a column has "db-name" set

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 7.0.0 DXP FP14, 7.0.0 DXP SP3, 7.0.3 CE GA4, 7.0.X EE, 7.1.X, 7.2.X, Master
• Component/s: Core Infrastructure > Service Builder
• Labels:
  • QA-F
  • liferay-digital-enterprise-70-sp3
  • liferay-fixpack-de-14-7010
• Branch Version/s:
  7.2.x, 7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Story Points: 1.5
• Fix Priority: 4
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/48369

Steps to reproduce the problem:

1. unzip the attached hello-world.zip
2. run ../gradlew deploy in hello-world-api and hello-world-service
3. run ../gradlew testIntegration in hello-world-test

FooPersistenceTest will fail with these stacktrace:

java.lang.IllegalArgumentException: Unknown column name fooId_
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.getColumnName(BasePersistenceImpl.java:459)
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.appendOrderByComparator(BasePersistenceImpl.java:410)
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.appendOrderByComparator(BasePersistenceImpl.java:389)
	at hello.world.service.persistence.impl.FooPersistenceImpl.findAll(FooPersistenceImpl.java:2613)
	at hello.world.service.persistence.impl.FooPersistenceImpl.findAll(FooPersistenceImpl.java:2563)
	at hello.world.service.persistence.test.FooPersistenceTest.testFindAll(FooPersistenceTest.java:229)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.jboss.arquillian.junit.Arquillian$8$1.invoke(Arquillian.java:370)
	at org.jboss.arquillian.container.test.impl.execution.LocalTestExecuter.execute(LocalTestExecuter.java:60)
	at sun.reflect.GeneratedMethodAccessor541.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:94)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(EventContextImpl.java:99)
	at org.jboss.arquillian.core.impl.EventContextImpl.proceed(EventContextImpl.java:81)
...