Theme CSS is not minified

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X EE, Master
• Fix Version/s: 7.0.0 DXP FP28, 7.0.X EE, 7.0.4 CE GA5, 7.1.X, Master
• Component/s: Frontend Infrastructure
• Labels:
  • liferay-digital-enterprise-70-sp5
  • liferay-fixpack-de-28-7010
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 2
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/50896

Theme CSS is not minified.

The underlying cause is that AggregateFilter needs to process theme CSS in order for it to be minified, but this is no longer true after LPS-70364. Prior to LPS-70364, the request path for theme CSS would be as follows:

AggregateFilter (portal) -> DynamicCSSFilter (portal) -> AggregateFilter (theme)

However, the fix for LPS-70364 was to ensure that DynamicCSSFilter runs for portlet CSS, where there are no additional filters processing the request (since they are regular OSGi bundles and not ones created from WARs).

Themes were also affected by this change, so after LPS-70364, the new request path for theme CSS is as follows.

AggregateFilter (portal) -> DynamicCSSFilter (portal)

Namely, AggregateFilter never has a chance to run on the theme servlet path.

Since theme CSS was minified by having it processed by AggregateFilter, one potential fix is to bring back the changes that made DynamicCSSFilter handle the content so that AggregateFilter also handles the content. This allows theme CSS to be processed by AggregateFilter.