Using bad portlet id in destroy phases

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.0 DXP FP20, 7.0.X EE, Master
• Fix Version/s: 7.0.X EE, 7.1.X, Master
• Component/s: Frontend Infrastructure
• Labels:
  • ee-ts
• Branch Version/s:
  7.0.x
• Fix Priority: 3

In many places we are using portletDisplay.getRootPortletId as a portleId to make a decision what portlet will be destroyed.

String portletId = portletDisplay.getRootPortletId();

var destroyInstance = function(event) \{
  if (event.portletId === '<%= portletId %>') \{
    try \{
      window['<%= name %>'].destroy();
    }
    catch (e) \{
    }

    Liferay.detach('destroyPortlet', destroyInstance);
  }
};

In case of instanceable portlets portletDisplay.getRootPortletId never match with current portlet id.

 

This pattern is used in the following places, we need to check where places are struggled with this mistake:

• alloyeditor.jsp - portal-master/modules/apps/foundation/frontend-editor/frontend-editoralloyeditor-web/src/main/resources/META-INF/resources
• bottom.jspf - portal-master/portal-web/docroot/html/taglib/ui/search_iterator/lexicon
• calendar_booking_recurrence_container.jspf - portal-master/modules/apps/forms-and-- workflow/calendar/calendar-web/src/main/resources/META-INF/resources
• ckeditor.jsp - portal-master/modules/apps/foundation/frontend-editor/frontend-editor-ckeditor-web/src/main/resources/META-INF/resources (2 matches)
• configuration.jsp - portal-master/modules/apps/web-experience/site-navigation/site-navigation-breadcrumb-web/src/main/resources/META-INF/resources
• edit_calendar_booking.jsp - portal-master/modules/apps/forms-and-workflow/calendar/calendar-web/src/main/resources/META-INF/resources (2 matches)
• edit_entry.jsp - portal-master/modules/apps/collaboration/blogs/blogs-web/src/main/resources/META-INF/resources/blogs
• edit_record_set.jsp - portal-master/modules/apps/forms-and-workflow/dynamic-data-lists/dynamic-data-lists-form-web/src/main/resources/META-INF/resources/admin
• end.jsp - portal-master/portal-web/docroot/html/taglib/aui/form
• form_builder.jspf - portal-master/modules/apps/forms-and-workflow/dynamic-data-mapping/dynamic-data-mapping-web/src/main/resources/META-INF/resources
• page.jsp - portal-master/modules/apps/collaboration/item-selector/item-selector-taglib/src/main/resources/META-INF/resources/image_selector
• page.jsp - portal-master/modules/apps/foundation/frontend-taglib/frontend-taglib/src/main/resources/META-INF/resources/management_bar
• page.jsp - portal-master/portal-web/docroot/html/taglib/ui/form_navigator
• page.jsp - portal-master/portal-web/docroot/html/taglib/ui/form_navigator/lexicon
• page.jsp - portal-master/portal-web/docroot/html/taglib/ui/input_asset_links
• reminder_queries.jsp - portal-master/modules/apps/foundation/users-admin/users-admin-web/src/main/resources/META-INF/resources/organization
• simple.jsp - portal-master/modules/apps/foundation/frontend-editor/frontend-editor-simple-web/src/main/resources/META-INF/resources
• sites.jsp - portal-master/modules/apps/foundation/users-admin/users-admin-web/src/main/resources/META-INF/resources/user
• start.jsp - portal-master/modules/apps/forms-and-workflow/dynamic-data-mapping/dynamic-data-mapping-taglib/src/main/resources/META-INF/resources/html
• steps.jspf - portal-master/portal-web/docroot/html/taglib/ui/form_navigator/lexicon
• tinymce_simple.jsp - portal-master/modules/apps/foundation/frontend-editor/frontend-editor-tinymce-web/src/main/resources/META-INF/resources
• tinymce.jsp - portal-master/modules/apps/foundation/frontend-editor/frontend-editor-tinymce-web/src/main/resources/META-INF/resources
• view_calendar.jsp - portal-master/modules/apps/forms-and-workflow/calendar/calendar-web/src/main/resources/META-INF/resources (2 matches)
• view_invite.jsp - portal-master/modules/apps/collaboration/invitation/invitation-invite-members-web/src/main/resources/META-INF/resources/invite_members
• view.jsp - portal-master/modules/apps/collaboration/document-library/document-library-web/src/main/resources/META-INF/resources/document_library
• view.jsp - portal-master/modules/apps/foundation/map/map-google-maps/src/main/resources/META-INF/resources
• view.jsp - portal-master/modules/apps/foundation/map/map-openstreetmap/src/main/resources/META-INF/resources
• view.jsp - portal-master/modules/apps/web-experience/journal/journal-web/src/main/resources/META-INF/resources

Removed portlets that didn't need to be changed.