Details

    • Type: Technical Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Completed
    • Affects Version/s: Master
    • Fix Version/s: 7.1.X, Master
    • Component/s: Calendar
    • Labels:

      Description

      In many places we are using portletDisplay.getRootPortletId as a portleId to make a decision what portlet will be destroyed.

      String portletId = portletDisplay.getRootPortletId();
      
      var destroyInstance = function(event) \{
        if (event.portletId === '<%= portletId %>') \{
          try \{
            window['<%= name %>'].destroy();
          }
          catch (e) \{
          }
      
          Liferay.detach('destroyPortlet', destroyInstance);
        }
      };
      

      In case of instanceable portlets portletDisplay.getRootPortletId never match with current portlet id.

      This pattern is used in the following places, we need to check where places are struggled with this mistake:

      calendar_booking_recurrence_container.jspf - portal-master/modules/apps/forms-and-- workflow/calendar/calendar-web/src/main/resources/META-INF/resources
      edit_calendar_booking.jsp - portal-master/modules/apps/forms-and-workflow/calendar/calendar-web/src/main/resources/META-INF/resources (2 matches)
      view_calendar.jsp - portal-master/modules/apps/forms-and-workflow/calendar/calendar-web/src/main/resources/META-INF/resources/view_calendar.jsp

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              brian.chan Brian Chan
              Reporter:
              jonathan.mak Jonathan Mak (Inactive)
              Recent user:
              Jason Pince
              Participants of an Issue:
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                4 years, 26 weeks, 2 days ago

                  Packages

                  Version Package
                  7.1.X
                  Master