Filter chain cache is not aware of a request's changing query string

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 6.2.X EE, 7.0.0 DXP FP30, 7.0.X EE, 7.0.4 CE GA5, 7.1.X, Master
• Component/s: Core Infrastructure
• Labels:
  • ee-ts
  • liferay-digital-enterprise-70-sp5
  • liferay-fixpack-de-30-7010
  • liferay-fixpack-portal-161-6210
• Branch Version/s:
  7.0.x, 6.2.x
• Backported to Branch:
  Committed
• Story Points: 1
• Fix Priority: 3
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/51262

Steps to Reproduce

1. For Master, deploy attached JAR. For 6.2.x, deploy attached WAR. Its URL regular expression pattern is

.+/.*test=.*

2. Go to http://localhost:8080/web/guest/home?test=asdf (Make sure that you have not previously visited the friendly URL /web/guest/home otherwise it will throw off this test)
3. Assert the following in the logs

ERROR [http-nio-8080-exec-1][UrlRegexFilter:53] Inside of the URL Regex Filter

4. Go to http://localhost:8080/web/guest/home
5. Assert the same message in the logs, despite the current URL not matching the regular expression

Note that LPS-73515 is required for testing this issue.

This happens because the invoker filter cache does not take into account the query string. However, the query string is checked against the regular expression within the filter mapping.

We either need to not cache requests with query strings or not match the query string with the regular expression.