Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-74358

NPM package infrastructure does not correctly parse AMD packages with a prolog before define()

    Details

      Description

      Typescript compiler generates AMD modules with some code before the define() call. This fools the portal into thinking that it is not a valid AMD module and the dependencies don't get parsed, making the module fail in the browser, at runtime.

      Steps to reproduce:

      1. Start the portal
      2. Deploy attached JAR
      3. Add a "Liferay NPM Angular.js Example" portlet to the main page

      Expected result:

      Some portlet content is rendered.

      Actual result:

      An empty portlet appears.

        Attachments

          Activity

            People

            Assignee:
            brian.lee Brian Lee
            Reporter:
            ivan.zaera Ivan Zaera
            Participants of an Issue:
            Recent user:
            Csaba Turcsan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Days since last comment:
              3 years, 12 weeks ago

                Packages

                Version Package
                7.0.0 DXP FP30
                7.0.X EE
                7.0.4 CE GA5
                7.1.X
                Master