Inefficiency in GroupImpl.isShowSite

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.2.X EE, 7.0.X, Master
• Fix Version/s: 7.0.0 DXP FP31, 7.0.5 CE GA6, 7.0.X, 7.1.X, Master
• Component/s: Sites Management
• Labels:
  • liferay-digital-enterprise-70-sp6
  • liferay-fixpack-de-31-7010
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 1
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/51540

Description
Inside of GroupImpl.isShowSite, a the hasPowerUserRole is computed before we know whether or not we need to use it. We should only compute this variable if we are going to use it, while still maintining the same level of code readability.

This issue is not testable by QA.