Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-74777

Poor Performance in v7_0_0.UpgradeDocumentLibrary#updateFileVersionFileNames

    Details

      Description

      Description
      The UpgradeDocumentLibrary#updateFileVersionFileNames process selects every single DLFileVersion and populates their fileNames one by one. We should rewrite this method to require as few SQL statements as possible.

      Steps to Reproduce
      1. Start up Liferay 6.2 connected to a fresh database.
      2. Log in as the admin user.
      3. Run the attached groovy script.
      4. Shut down Liferay.
      5. Attempt to upgrade to Liferay 7 (NOTE: You probably want to make sure LPS-74690 has been committed, otherwise the upgrade might not get far enough for you to test this issue).
      6. Observe the length of time it takes to run the v7_0_0.UpgradeDocumentLibrary#updateFileVersionFileNames process.

      Expected Result: The upgrade process completes within 10 seconds.
      Actual Result: The upgrade process takes about five minutes to run.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                abel.yu Abel Yu (Inactive)
                Reporter:
                michael.bowerman Michael Bowerman (Inactive)
                Participants of an Issue:
                Recent user:
                Csaba Turcsan
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since last comment:
                  2 years, 22 weeks, 2 days ago

                  Packages

                  Version Package
                  7.0.0 DXP FP46
                  7.0.6 CE GA7
                  7.0.0 DXP SP8
                  7.0.X
                  7.1.0 M2
                  7.1.X
                  Master