When saving a ddmstructure, each JournalArticle version is indexed as many times as versions exists in each JournalArticle

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.2.X EE, 7.0.X, Master
• Fix Version/s: 6.2.X EE, 7.0.0 DXP FP33, 7.0.0 DXP SP7, 7.0.5 CE GA6, 7.0.X, 7.1.X, Master
• Component/s: Dynamic Data Mapping, Web Content > Web Content Administration
• Labels:
  • NAT
  • ee-ts
  • liferay-digital-enterprise-70-sp7
  • liferay-fixpack-de-33-7010
  • liferay-fixpack-portal-164-6210
• Branch Version/s:
  7.0.x, 6.2.x
• Backported to Branch:
  Committed
• Story Points: 1.25
• Fix Priority: 4
• Git Pull Request: https://github.com/liferay/com-liferay-journal/pull/502
• Bug Type: Regression Bug

When saving a ddmstructure, each JournalArticle version is indexed as many times as versions exists in each JournalArticle.

If you have a webcontent with 4 versions, we are indexing it 4*4=16 times.

In 6.2.x similar error is produced when you configure journal.articles.index.all.versions=false in portal-ext.properties
In that case if you have a webcontent with 4 versions, only last version is indexed but it is indexed 4 times

Root cause

In LPS-57161, Index buffer was applied to JournalArticleIndexer.reindexDDMStructures method, see following pulls:

• https://github.com/brianchandotcom/liferay-portal/pull/28348
• https://github.com/brianchandotcom/liferay-portal/pull/29350
  Call to index.reindex(classname, resourcePK) is better, because new index buffering removes the duplicates requests

But in LPS-51356 call to "JournalArticleIndexer.reindexDDMStructures" method was moved from DDMStructureLocalServiceImpl to DDMStructureIndexerBackgroundTaskExecutor.
This change causes this issue because in that background task there is no database transaction, so there is no Index Buffer that removes the duplicated requests to index.reindex(classname, resourcePK)

Steps to reproduce (7.0.x and master)

1. Create a structure
2. Create a webcontent with 4 versions (versions 1.0 to 1.3) using the new structure
3. Activate log category com.liferay.portal.search.internal.IndexWriterHelperImpl to DEBUG level
4. Modify the structure and save it. A background reindex is launched
5. Check log traces with DEBUG [liferay/background_task-1][IndexWriterHelperImpl] and count them:
   • Expected behavior: 4 lines with the requests to the index are written to the log
   • Wrong behavior: 16 lines with the requests to the index are written to the log
      

Steps to reproduce (6.2.x)

1. Configure journal.articles.index.all.versions=false in portal-ext.properties (only last version is indexed with this property)
2. Create a structure
3. Create a webcontent with 4 versions (versions 1.0 to 1.3) using the new structure
4. Activate log category com.liferay.portal.kernel.search.SearchEngineUtil to DEBUG level
5. Modify the structure and save it. A background reindex is launched
6. Check log traces with DEBUG [liferay/background_task-1][IndexWriterHelperImpl] and count them:
   • Expected behavior: 1 lines with the request to the index is written to the log
   • Wrong behavior: 4 lines with the requests to the index are written to the log