build.number property in an app's service.properties file is becoming buildNumber for the portlet

• Type: Regression Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, Master
• Fix Version/s: 7.0.0 DXP FP36, 7.0.0 DXP SP7, 7.0.5 CE GA6, 7.0.X, 7.1.0 M1, 7.1.X, Master
• Component/s: App Management > Plugins Configuration, Portal Configuration > Portal Settings
• Labels:
  • liferay-digital-enterprise-70-sp7
  • liferay-fixpack-de-36-7010
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 4
• Last Working Version:
  7.0.0 DXP FP27
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/54256

Issue: The build.number property in an app's service.properties file is becoming buildNumber for the portlet, when buildNumber should be coming from release.info.build.number, which is set in [portlet_war]\WEB-INF\classes\portal.properties.

Steps to reproduce:

1. Drop RTG Survey lpkg file into home/deploy folder (or any lpkg file where both build.number and release.info.build.number are set (to differing values))
2. Startup 7.0.x/DXP bundle

Expected result:
The app will deploy successfully during server startup.

Actual result:
The app begins to deploy:

2018-01-05 02:05:33.271 INFO  [com.liferay.portal.kernel.deploy.auto.AutoDeployScanner][AutoDeployDir:262] Processing RTG Survey - Liferay DXP_ Digital Enterprise 7.0.lpkg
2018-01-05 02:05:45.770 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][LPKGIndexValidator:189] Passed integrity check
2018-01-05 02:05:46.510 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][BaseAutoDeployListener:43] Copying portlets for D:\script\Home\liferay-dxp-digital-enterprise-7.0-ga1\tomcat-8.0.32\temp\20180105020546481BNDDQZVJ\rtg-survey-portlet.war
2018-01-05 02:05:46.574 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][BaseDeployer:873] Deploying rtg-survey-portlet.war
2018-01-05 02:05:47.356 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][BaseAutoDeployListener:50] Portlets for D:\script\Home\liferay-dxp-digital-enterprise-7.0-ga1\tomcat-8.0.32\temp\20180105020546481BNDDQZVJ\rtg-survey-portlet.war copied successfully
2018-01-05 02:05:59.938 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][HotDeployImpl:226] Deploying rtg-survey-portlet from queue
2018-01-05 02:05:59.939 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][PluginPackageUtil:1019] Reading plugin package for rtg-survey-portlet
2018-01-05 02:06:00.338 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][HookHotDeployListener:457] Registering hook for rtg-survey-portlet

but then throws the following error:

2018-01-05 02:06:00.346 ERROR [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][HotDeployImpl:240] com.liferay.portal.kernel.deploy.hot.HotDeployException: Error registering hook for rtg-survey-portlet
com.liferay.portal.kernel.deploy.hot.HotDeployException: Error registering hook for rtg-survey-portlet
	at com.liferay.portal.kernel.deploy.hot.BaseHotDeployListener.throwHotDeployException(BaseHotDeployListener.java:38)
	at com.liferay.portal.deploy.hot.HookHotDeployListener.invokeDeploy(HookHotDeployListener.java:275)
	at com.liferay.portal.deploy.hot.HotDeployImpl.doFireDeployEvent(HotDeployImpl.java:237)
	at com.liferay.portal.deploy.hot.HotDeployImpl.fireDeployEvent(HotDeployImpl.java:104)
	at com.liferay.portal.kernel.deploy.hot.HotDeployUtil.fireDeployEvent(HotDeployUtil.java:28)
	at com.liferay.portal.kernel.servlet.PluginContextListener.fireDeployEvent(PluginContextListener.java:182)
	at com.liferay.portal.kernel.servlet.PluginContextListener.doPortalInit(PluginContextListener.java:172)
	at com.liferay.portal.kernel.util.BasePortalLifecycle.portalInit(BasePortalLifecycle.java:44)
	at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:76)
	at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:59)
	at com.liferay.portal.kernel.util.BasePortalLifecycle.registerPortalLifecycle(BasePortalLifecycle.java:54)
	at com.liferay.portal.kernel.servlet.PluginContextListener.contextInitialized(PluginContextListener.java:134)
	at com.liferay.portal.kernel.servlet.SecurePluginContextListener.contextInitialized(SecurePluginContextListener.java:152)
	at com.liferay.portal.osgi.web.wab.extender.internal.adapter.ServletContextListenerExceptionAdapter.contextInitialized(ServletContextListenerExceptionAdapter.java:51)
	at sun.reflect.GeneratedMethodAccessor848.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.eclipse.equinox.http.servlet.internal.registration.ListenerRegistration$EventListenerInvocationHandler.invoke(ListenerRegistration.java:145)
	at com.sun.proxy.$Proxy508.contextInitialized(Unknown Source)
	at org.eclipse.equinox.http.servlet.internal.context.ContextController.doAddListenerRegistration(ContextController.java:357)
	at org.eclipse.equinox.http.servlet.internal.context.ContextController.addListenerRegistration(ContextController.java:310)
	at org.eclipse.equinox.http.servlet.internal.customizer.ContextListenerTrackerCustomizer.addingService(ContextListenerTrackerCustomizer.java:67)
	at org.eclipse.equinox.http.servlet.internal.customizer.ContextListenerTrackerCustomizer.addingService(ContextListenerTrackerCustomizer.java:1)
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:941)
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:1)
	at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
	at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
	at org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:901)
	at org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:109)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:917)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
	at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEventPrivileged(ServiceRegistry.java:862)
	at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEvent(ServiceRegistry.java:801)
	at org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl.register(ServiceRegistrationImpl.java:127)
	at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.registerService(ServiceRegistry.java:225)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.registerService(BundleContextImpl.java:464)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.registerService(BundleContextImpl.java:482)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.registerService(BundleContextImpl.java:1001)
	at com.liferay.portal.osgi.web.wab.extender.internal.WabBundleProcessor.initListeners(WabBundleProcessor.java:573)
	at com.liferay.portal.osgi.web.wab.extender.internal.WabBundleProcessor.init(WabBundleProcessor.java:203)
	at com.liferay.portal.osgi.web.wab.extender.internal.WebBundleDeployer._initWabBundle(WebBundleDeployer.java:186)
	at com.liferay.portal.osgi.web.wab.extender.internal.WebBundleDeployer.doStart(WebBundleDeployer.java:106)
	at com.liferay.portal.osgi.web.wab.extender.internal.WabFactory$WABExtension.start(WabFactory.java:158)
	at org.apache.felix.utils.extender.AbstractExtender.createExtension(AbstractExtender.java:259)
	at org.apache.felix.utils.extender.AbstractExtender.modifiedBundle(AbstractExtender.java:232)
	at org.osgi.util.tracker.BundleTracker$Tracked.customizerModified(BundleTracker.java:482)
	at org.osgi.util.tracker.BundleTracker$Tracked.customizerModified(BundleTracker.java:1)
	at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:232)
	at org.osgi.util.tracker.BundleTracker$Tracked.bundleChanged(BundleTracker.java:444)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:905)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
	at org.eclipse.osgi.internal.framework.EquinoxEventPublisher.publishBundleEventPrivileged(EquinoxEventPublisher.java:165)
	at org.eclipse.osgi.internal.framework.EquinoxEventPublisher.publishBundleEvent(EquinoxEventPublisher.java:75)
	at org.eclipse.osgi.internal.framework.EquinoxEventPublisher.publishBundleEvent(EquinoxEventPublisher.java:67)
	at org.eclipse.osgi.internal.framework.EquinoxContainerAdaptor.publishModuleEvent(EquinoxContainerAdaptor.java:102)
	at org.eclipse.osgi.container.Module.publishEvent(Module.java:461)
	at org.eclipse.osgi.container.Module.start(Module.java:452)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:402)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:421)
	at com.liferay.portal.lpkg.deployer.util.BundleStartLevelUtil._startBundle(BundleStartLevelUtil.java:61)
	at com.liferay.portal.lpkg.deployer.util.BundleStartLevelUtil.setStartLevelAndStart(BundleStartLevelUtil.java:44)
	at com.liferay.portal.lpkg.deployer.internal.wrapper.bundle.URLStreamHandlerServiceServiceTrackerCustomizer.addingService(URLStreamHandlerServiceServiceTrackerCustomizer.java:86)
	at com.liferay.portal.lpkg.deployer.internal.wrapper.bundle.URLStreamHandlerServiceServiceTrackerCustomizer.addingService(URLStreamHandlerServiceServiceTrackerCustomizer.java:33)
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:941)
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:1)
	at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
	at org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
	at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:318)
	at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:261)
	at com.liferay.portal.lpkg.deployer.internal.wrapper.bundle.WARBundleWrapperBundleActivator.start(WARBundleWrapperBundleActivator.java:77)
	at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:774)
	at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:1)
	at java.security.AccessController.doPrivileged(Native Method)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:767)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.start(BundleContextImpl.java:724)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.startWorker0(EquinoxBundle.java:951)
	at org.eclipse.osgi.internal.framework.EquinoxBundle$EquinoxModule.startWorker(EquinoxBundle.java:328)
	at org.eclipse.osgi.container.Module.doStart(Module.java:566)
	at org.eclipse.osgi.container.Module.start(Module.java:434)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:402)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:421)
	at com.liferay.portal.lpkg.deployer.util.BundleStartLevelUtil._startBundle(BundleStartLevelUtil.java:61)
	at com.liferay.portal.lpkg.deployer.util.BundleStartLevelUtil.setStartLevelAndStart(BundleStartLevelUtil.java:44)
	at com.liferay.portal.lpkg.deployer.internal.LPKGBundleTrackerCustomizer.addingBundle(LPKGBundleTrackerCustomizer.java:245)
	at com.liferay.portal.lpkg.deployer.internal.LPKGBundleTrackerCustomizer.addingBundle(LPKGBundleTrackerCustomizer.java:84)
	at org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:469)
	at org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:1)
	at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
	at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
	at org.osgi.util.tracker.BundleTracker$Tracked.bundleChanged(BundleTracker.java:444)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:905)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
	at org.eclipse.osgi.internal.framework.EquinoxEventPublisher.publishBundleEventPrivileged(EquinoxEventPublisher.java:165)
	at org.eclipse.osgi.internal.framework.EquinoxEventPublisher.publishBundleEvent(EquinoxEventPublisher.java:75)
	at org.eclipse.osgi.internal.framework.EquinoxEventPublisher.publishBundleEvent(EquinoxEventPublisher.java:67)
	at org.eclipse.osgi.internal.framework.EquinoxContainerAdaptor.publishModuleEvent(EquinoxContainerAdaptor.java:102)
	at org.eclipse.osgi.container.ModuleContainer.applyDelta(ModuleContainer.java:691)
	at org.eclipse.osgi.container.ModuleContainer.resolveAndApply(ModuleContainer.java:491)
	at org.eclipse.osgi.container.ModuleContainer.resolve(ModuleContainer.java:437)
	at org.eclipse.osgi.container.ModuleContainer.resolve(ModuleContainer.java:427)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.resolve(EquinoxBundle.java:977)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.findEntries(EquinoxBundle.java:679)
	at com.liferay.portal.license.deployer.internal.LPKGLicensedBundleTrackerCustomizer.addingBundle(LPKGLicensedBundleTrackerCustomizer.java:57)
	at com.liferay.portal.license.deployer.internal.LPKGLicensedBundleTrackerCustomizer.addingBundle(LPKGLicensedBundleTrackerCustomizer.java:40)
	at org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:469)
	at org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:1)
	at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
	at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
	at org.osgi.util.tracker.BundleTracker$Tracked.bundleChanged(BundleTracker.java:444)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:905)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
	at org.eclipse.osgi.internal.framework.EquinoxEventPublisher.publishBundleEventPrivileged(EquinoxEventPublisher.java:165)
	at org.eclipse.osgi.internal.framework.EquinoxEventPublisher.publishBundleEvent(EquinoxEventPublisher.java:75)
	at org.eclipse.osgi.internal.framework.EquinoxEventPublisher.publishBundleEvent(EquinoxEventPublisher.java:67)
	at org.eclipse.osgi.internal.framework.EquinoxContainerAdaptor.publishModuleEvent(EquinoxContainerAdaptor.java:102)
	at org.eclipse.osgi.container.ModuleContainer.install(ModuleContainer.java:259)
	at org.eclipse.osgi.storage.Storage.install(Storage.java:517)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.installBundle(BundleContextImpl.java:146)
	at com.liferay.portal.lpkg.deployer.internal.DefaultLPKGDeployer.deploy(DefaultLPKGDeployer.java:162)
	at com.liferay.marketplace.deployer.LPKGArtifactInstaller.install(LPKGArtifactInstaller.java:70)
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:937)
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:871)
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:485)
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)
	at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:312)
Caused by: com.liferay.portal.kernel.upgrade.OlderVersionException: Skipping upgrade processes for rtg-survey-portlet because you are trying to upgrade with an older version
	at com.liferay.portal.service.impl.ReleaseLocalServiceImpl.updateRelease(ReleaseLocalServiceImpl.java:304)
	at com.liferay.portal.service.impl.ReleaseLocalServiceImpl.updateRelease(ReleaseLocalServiceImpl.java:337)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:163)
	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:54)
	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:58)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:137)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:137)
	at com.liferay.portal.spring.aop.ServiceBeanAopProxy.invoke(ServiceBeanAopProxy.java:169)
	at com.sun.proxy.$Proxy245.updateRelease(Unknown Source)
	at com.liferay.portal.kernel.service.ReleaseLocalServiceUtil.updateRelease(ReleaseLocalServiceUtil.java:301)
	at com.liferay.portal.deploy.hot.HookHotDeployListener.initPortalProperties(HookHotDeployListener.java:1766)
	at com.liferay.portal.deploy.hot.HookHotDeployListener.initPortalProperties(HookHotDeployListener.java:1320)
	at com.liferay.portal.deploy.hot.HookHotDeployListener.doInvokeDeploy(HookHotDeployListener.java:468)
	at com.liferay.portal.deploy.hot.HookHotDeployListener.invokeDeploy(HookHotDeployListener.java:272)
	... 127 more
2018-01-05 02:06:01.038 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][PortletHotDeployListener:182] Registering portlets for rtg-survey-portlet
2018-01-05 02:06:01.540 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][PortletHotDeployListener:299] 3 portlets for rtg-survey-portlet are available for use
2018-01-05 02:06:01.541 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][SocialHotDeployListener:88] Registering social for rtg-survey-portlet
2018-01-05 02:06:01.542 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][SocialHotDeployListener:97] Social for rtg-survey-portlet is available for use
2018-01-05 02:06:01.748 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][BundleStartStopLogger:35] STARTED rtg-survey-portlet_7.0.0.21 [637]
2018-01-05 02:06:01.752 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][BundleStartStopLogger:35] STARTED RTG Survey-rtg-survey-portlet-wrapper_7.0.0.21 [636]
2018-01-05 02:06:01.778 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][LicenseManager:?] RTG Survey license validation passed
2018-01-05 02:06:01.780 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][LicenseManager:?] License registered for RTG Survey
2018-01-05 02:06:05.115 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][LPKGIndexValidator:235] Updated D:\script\Home\liferay-dxp-digital-enterprise-7.0-ga1\osgi\target-platform\integrity.properties
2018-01-05 02:06:05.120 INFO  [fileinstall-D:/script/Home/liferay-dxp-digital-enterprise-7.0-ga1/osgi/marketplace][BundleStartStopLogger:35] STARTED RTG Survey_1.5.7 [635]