PortletIdCodec.PORTLET_INSTANCE_KEY_MAX_LENGTH is too long

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, Master
• Fix Version/s: 7.0.0 DXP FP33, 7.0.0 DXP SP7, 7.0.5 CE GA6, 7.0.X, 7.1.0 M1, 7.1.X, Master
• Component/s: Portal Services > Configuration Management > Portlets
• Labels:
  • liferay-digital-enterprise-70-sp7
  • liferay-fixpack-de-33-7010
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 2
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/53527

The PortletIdCodec.PORTLET_INSTANCE_KEY_MAX_LENGTH variable appears to be intended to prevent developers from giving a portlet a portletId that can potentially overflow the length of relevant columns in the database (for instance, the name column in the ResourcePermission table). However, the variable is not being computed properly, and the value of the variable ends up being 290, which is greater than the 255-character length of these columns. This can potentially lead to SQL errors if a developer tries to deploy a custom portlet with a portletId greater than 255 characters in length.