Related Assets Performance Issue with Large Number of Organization Child Sites

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, Master
• Fix Version/s: 7.0.0 DXP FP40, 7.0.0 DXP SP7, 7.0.5 CE GA6, 7.0.X, 7.1.0 M1, 7.1.X, Master
• Component/s: Performance
• Labels:
  • ee-ts
  • liferay-digital-enterprise-70-sp7
  • liferay-fixpack-de-40-7010
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed
• Story Points: 1
• Fix Priority: 4
• Git Pull Request: https://github.com/pavel-savinov/liferay-portal/pull/142

When attempting to add a related asset to an asset, if there is a large amount of child sites, the portal will take a very long time to retrieve the list of related assets.  This issue has been sped-up in other locations, however this fix relates directly to the traversal of possible child-sites.  The cause of this performance hit is in AssetBrowserDisplayContext.getManagementBarFilterItem(), where we fetch each child site's group one at a time.  The resolution will be to retrieve all groups at once.

Steps to reproduce:

1. Create a new site called "Parent site".
2. Create 5000 child sites to the parent site.  You can use the attached script to complete this step (make sure to fill out the variables for userId and parentGroupId).
3. Within "Parent site", create a web content "Content A"
4. Create another content "Content B" and attempt to add a related asset to it.

Expected Results: Content A appears in the related assets list

Actual Results: The related assets list takes a very long time to load (if at all).

Reproduced in Master: 3a7404926f1196b77010467df0174365a1c0f208