Use the entrySet() iterator when retrieving values from a Map

• Type: Story
• Status: Closed
• Priority: Trivial
• Resolution: Completed
• Affects Version/s: None
• Fix Version/s: 7.0.0 DXP FP35, 7.0.0 DXP SP7, 7.0.5 CE GA6, 7.0.X, 7.1.X, Master
• Component/s: Dev Tools > Source Formatter, Performance
• Labels:
  • liferay-digital-enterprise-70-sp7
  • liferay-fixpack-de-35-7010
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed
• Epic Link: Source Formatter UX

Use the entrySet() iterator when retrieving values from a Map, instead of retrieving values from the Map while iterating over the Map keys using keySet(). Performance of this is better than calling Map.get(key) for each entry while iterating also.

Example:

bad performance:

for (String name : map.keySet()) {
 String value = map.getValue(name);
...
}

 

good performance:

 

for (Map.Entry<String, String> entry : map.entrySet()) {
 String value = entry.getValue();
...
}