Adding StagingPermissionChecker breaks SearchPermissionCheckerTest

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.2.X EE
• Fix Version/s: 6.2.X EE
• Component/s: Application Security > Permissions
• Labels:
  • INACTIVE
  • ee-6.2.x-only
  • liferay-fixpack-portal-168-6210
• Fix Priority: 3
• Git Pull Request: https://github.com/balazssk/liferay-portal-ee/pull/5

 

After adding LPS-61794, (introduction of StagingPermissionChecker) SearchPermissionCheckerTest fails with the following:

AXIS_VARIABLE=0,label_exp=!master #382
SearchPermissionCheckerTest.testGroupPermissionFilter
junit.framework.AssertionFailedError: expected:<true> but was:<false>
	at com.liferay.portal.search.SearchPermissionCheckerTest.assertFieldValue(SearchPermissionCheckerTest.java:266)
	at com.liferay.portal.search.SearchPermissionCheckerTest.assertFieldValue(SearchPermissionCheckerTest.java:255)
	at com.liferay.portal.search.SearchPermissionCheckerTest.testGroupPermissionFilter(SearchPermissionCheckerTest.java:154)
	at com.liferay.portal.kernel.test.RunBeforeTestMethodCallback.evaluate(RunBeforeTestMethodCallback.java:45)
	at com.liferay.portal.kernel.test.RunAfterTestMethodCallback.evaluate(RunAfterTestMethodCallback.java:49)
	at com.liferay.portal.kernel.test.RunBeforeTestClassesCallback.evaluate(RunBeforeTestClassesCallback.java:39)
	at com.liferay.portal.kernel.test.RunAfterTestClassesCallback.evaluate(RunAfterTestClassesCallback.java:42)
	at com.liferay.portal.test.LiferayIntegrationJUnitTestRunner$1.evaluate(LiferayIntegrationJUnitTestRunner.java:74)
SearchPermissionCheckerTest.testGuestPermissionFilter
junit.framework.AssertionFailedError: expected:<true> but was:<false>
	at com.liferay.portal.search.SearchPermissionCheckerTest.assertFieldValue(SearchPermissionCheckerTest.java:266)
	at com.liferay.portal.search.SearchPermissionCheckerTest.assertFieldValue(SearchPermissionCheckerTest.java:255)
	at com.liferay.portal.search.SearchPermissionCheckerTest.testGuestPermissionFilter(SearchPermissionCheckerTest.java:194)
	at com.liferay.portal.kernel.test.RunBeforeTestMethodCallback.evaluate(RunBeforeTestMethodCallback.java:45)
	at com.liferay.portal.kernel.test.RunAfterTestMethodCallback.evaluate(RunAfterTestMethodCallback.java:49)
	at com.liferay.portal.kernel.test.RunBeforeTestClassesCallback.evaluate(RunBeforeTestClassesCallback.java:39)
	at com.liferay.portal.kernel.test.RunAfterTestClassesCallback.evaluate(RunAfterTestClassesCallback.java:42)
	at com.liferay.portal.test.LiferayIntegrationJUnitTestRunner$1.evaluate(LiferayIntegrationJUnitTestRunner.java:74)
SearchPermissionCheckerTest.testOrganizationRolePermissionFilter
junit.framework.AssertionFailedError: expected:<true> but was:<false>
	at com.liferay.portal.search.SearchPermissionCheckerTest.assertFieldValue(SearchPermissionCheckerTest.java:266)
	at com.liferay.portal.search.SearchPermissionCheckerTest.assertFieldValue(SearchPermissionCheckerTest.java:255)
	at com.liferay.portal.search.SearchPermissionCheckerTest.testOrganizationRolePermissionFilter(SearchPermissionCheckerTest.java:217)
	at com.liferay.portal.kernel.test.RunBeforeTestMethodCallback.evaluate(RunBeforeTestMethodCallback.java:45)
	at com.liferay.portal.kernel.test.RunAfterTestMethodCallback.evaluate(RunAfterTestMethodCallback.java:49)
	at com.liferay.portal.kernel.test.RunBeforeTestClassesCallback.evaluate(RunBeforeTestClassesCallback.java:39)
	at com.liferay.portal.kernel.test.RunAfterTestClassesCallback.evaluate(RunAfterTestClassesCallback.java:42)
	at com.liferay.portal.test.LiferayIntegrationJUnitTestRunner$1.evaluate(LiferayIntegrationJUnitTestRunner.java:74)
...
AXIS_VARIABLE=16,label_exp=!master #382
JournalArticleSearchTest.testBaseModelUserPermissions
junit.framework.AssertionFailedError: expected:<0> but was:<1>
	at com.liferay.portlet.journal.search.JournalArticleSearchTest.checkUserPermissionsBaseModelsSearchCount(JournalArticleSearchTest.java:317)
	at com.liferay.portal.search.BaseSearchTestCase.testUserPermissions(BaseSearchTestCase.java:937)
	at com.liferay.portal.search.BaseSearchTestCase.testBaseModelUserPermissions(BaseSearchTestCase.java:78)
	at com.liferay.portal.kernel.test.RunBeforeTestMethodCallback.evaluate(RunBeforeTestMethodCallback.java:45)
	at com.liferay.portal.kernel.test.RunAfterTestMethodCallback.evaluate(RunAfterTestMethodCallback.java:49)
	at com.liferay.portal.kernel.test.RunBeforeTestClassesCallback.evaluate(RunBeforeTestClassesCallback.java:39)
	at com.liferay.portal.kernel.test.RunAfterTestClassesCallback.evaluate(RunAfterTestClassesCallback.java:42)
	at com.liferay.portal.test.LiferayIntegrationJUnitTestRunner$1.evaluate(LiferayIntegrationJUnitTestRunner.java:74)

The solution would be to remove SearchPermissionChecker's dependency on AdvancedPermissionChecker, much like how it was done on master in LPS-57227