Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

cleanServiceBuilder task fails for SQL Server databases

Description

Description
The gradlew cleanServiceBuilder task attempts to drop all tables in your database in your module's service.xml. The way it does this is by running a DROP TABLE IF EXISTS SQL command directly on the database. However, the "IF EXISTS" syntax is not supported on all of our supported databases, such as SQL Server versions before 2016.

Steps to Reproduce
1. Set up a sample module in blade.
2. In your service's jdbc.properties, set jdbc properties to connect it to a SQL Server database.
3. From your service folder, attempt to run the gradlew cleanServiceBuilder task.

Expected Result: The task completes successfully without errors.
Actual Result: The task fails with the following error:

Attachments

1

Activity

Show:

Michael Bowerman January 17, 2018 at 7:50 AM

Thanks ! Glad you were able to get it working!

Sharry Shi January 16, 2018 at 9:10 PM

Unable to test the issue on Master, since master not support sql server 2012/2014/2016.

Tried to test the issue on:
Tomcat 8.0.32 + MySQL 5.6. Portal master GIT ID: 3598ffe657e6e16965c88c96e05435e8b67e5e69.

Got Unsupported database type sqlserver error on console

Sharry Shi January 16, 2018 at 6:51 PM
Edited

PASSED Manual Testing using the following steps:

  1. Start bundle with sql serever2012 to generate database tables

  2. Unzip the attached module into _src_home/modules

  3. Modify the jdbc.properties to connect sql serrver 2012

  4. Update the version of com.liferay.gradle.plugins to 3.5.89 in build.gradle

  5. Run gradlew cleanServiceBuilder task

Fixed on:

Tomcat 8.0.32 + MySQL 5.6. Portal 7.0.x-private GIT ID: f16ff12a96fb6abd3eb52bf3123bb3e9e10f833c.

The task completes successfully without errors. Works for both sql server 2012 and sql server 2016.

Michael Bowerman January 16, 2018 at 7:51 AM

Hi ,

Sorry for the bad example. Could you modify the build.gradle in the module so that it is using version 3.5.89 of the com.liferay.gradle.plugins module (instead of version 3.3.9)? That should force it to use the fixed version of Service Builder. Thanks!

Sharry Shi January 16, 2018 at 2:21 AM

Hello
Thanks for your reply, I was trying to run the gradlew cleanServiceBuilder task under the module you provided with connecting sql server 2012 on local, but got the same as in your description. I've placed the module you provide under modules folder in master and 7.0.x-private separately.

  1. Do we need to test the issue against sql server 2016 or above?

  2. Do we need to test the issue against our branch? Or we can place the module anywhere, if the task works that means the issue is fixed on all branches?
    Thanks for any of your reply.

Fixed

Details

Assignee

Reporter

Labels

Branch Version/s

7.0.x

Backported to Branch

Committed

Fix Priority

3

Git Pull Request

Story Points

Components

Fix versions

Affects versions

Priority

Zendesk Support

Created January 5, 2018 at 9:15 AM
Updated June 26, 2023 at 1:49 AM
Resolved January 12, 2018 at 2:09 PM
Loading...