Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-77945

JournalServiceVerifyProcess.verifyOracleNewLine() can be removed

    Details

    • Type: Story
    • Status: Closed
    • Priority: Critical
    • Resolution: Completed
    • Affects Version/s: 7.0.X, Master
    • Fix Version/s: 7.1.X, Master
    • Component/s: WCM > Upgrade
    • Labels:
      None

      Description

      JournalServiceVerifyProcess.verifyOracleNewLine() can be removed

      • If database is not oracle, it returns at the begining
      • For oracle databases, calls journalArticleLocalService.checkNewLine for all JournalArticles of groupId=14

      Last logic change was done in LPS-32454. Before that LPS, we also executed journalArticleLocalService.checkNewLine in the all structures and templates of groupId=14, see:

      After some investigations, the original version of this verify was added 12 years ago in following commit (no Jira ticket exists):

      ...due a old Oracle bug, see comment inside the code:

      		// This is a workaround for a limitation in Oracle sqlldr's inability
      		// insert new line characters for long varchar columns. See
      		// http://forums.liferay.com/index.php?showtopic=2761&hl=oracle for more
      		// information. Check several articles because some articles may not
      		// have new lines.
      

      The URL with they full explanation of the issue is not available

      This code was moved from original FixOracleAction to VerifyOracle (LEP-5199) and it was moved from VerifyOracle to VerifyJournal (LPS-1519)

      So this old code seems to solve an old Oracle issue, only for groupId=14.
      That groupId is not normal for newer Liferay installations (6.0+) so I think we can remove this verify as all older Liferay installations must stop in 6.1 or 6.2 before upgrading to 7.0 and verify will be executed in that moment.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                kyle.miho Kyle Miho
                Reporter:
                jorge.diaz Jorge Diaz
                Recent user:
                Jason Pince
                Participants of an Issue:
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Packages

                  Version Package
                  7.1.X
                  Master