Details

      Description

      Reproducing steps

      1. Add a new key to portal-impl/src/content/language.properties
      2. Go to $liferay_portal/portal-impl and run ant build-lang

      Expected: The key is propagated to all language-properties files.
      Observed: The process stops at the first language-properties file (language_ar.properties) and the following error stack appears:

      Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=2048m; support was removed in 8.0
      Buildfile: /home/ricardo/Support/Code/liferay-ce/portal/portal-impl/build.xml
      
      build-lang:
      
      build-lang-cmd:
           [java] Exception in thread "main" java.lang.RuntimeException: File ar with state 9 has key lang.dir
           [java]     at com.liferay.lang.builder.LangBuilder._createProperties(LangBuilder.java:376)
           [java]     at com.liferay.lang.builder.LangBuilder._createProperties(LangBuilder.java:312)
           [java]     at com.liferay.lang.builder.LangBuilder.<init>(LangBuilder.java:206)
           [java]     at com.liferay.lang.builder.LangBuilder.main(LangBuilder.java:111)
           [java] Java Result: 1
      
      BUILD SUCCESSFUL
      Total time: 4 seconds

      Comment

      The problems seems to be that the method com.liferay.lang.builder.LangBuilder._createProperties(String, String, String) tries to match a line starting with

      ## Language settings

      in the language-properties file, but this has been source-formatted via com.liferay.source.formatter.checks.PropertiesCommentsCheck to

      ## Language Settings

      (note the capital S).

        Attachments

          Activity

            People

            • Assignee:
              andrea.digiorgi Andrea Di Giorgi (Inactive)
              Reporter:
              ricardo.couso Ricardo Couso
              Participants of an Issue:
              Recent user:
              Jason Pince
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                1 year, 17 weeks, 5 days ago

                Packages

                Version Package
                7.1.0 M2
                7.1.X
                Master