Deprecated Hibernate method used by CounterFinderImpl

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, Master
• Fix Version/s: 7.0.0 DXP FP47, 7.0.0 DXP SP8, 7.0.X, 7.1.0 Alpha, 7.1.X, Master
• Component/s: Core Infrastructure > ORM, Portal Services > Counter Service
• Labels:
  • ee-ts
  • liferay-digital-enterprise-70-sp8
  • liferay-fixpack-de-47-7010
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/56962

Description
The CounterFinderImpl class makes use of a session.get method which has been deprecated since 6.1. The method ultimately calls Hibernate's session.get(Class, Serializable, LockMode) method, which according to the JavaDoc, is deprecated and should be replaced with a call to session.get(Class, Serializable, LockOptions) instead.

Because we are using this deprecated method, we are allowing for the possibility of a deadlock when Hibernate tries to retrieve a lock. By utilizing LockOptions, we can set a timeout when retrieving the lock, which will prevent such a deadlock from causing the portal to hang.

Steps to Reproduce
N/A