Details

      Description

      • It looks like class fields are removed if they aren't used in the file where they're defined. We have classes written in JSPs that just define public constants, so all of those constants end up being removed if we don't add the files to "jsp.unused.variables.excludes". Examples: portlet_props_keys.jspf (all variables removed), *_constants.jspf (all variables not used in class methods are removed). This has actually been a longstanding issue, but it was easy to work around so I haven't mentioned it before
      • Fully Qualified Names are not allowed in JSPs (Checkstyle:FullyQualifiedNameCheck). But what if we have multiple imports with the same simple name? This is especially problematic since all JSP imports must be in the init.jsp file (SourceCheck:JSPImportsCheck) – so if you have any conflicting names across all your JSPs, there's no way to correctly resolve the imports without excluding files from source formatter. In Testray we have conflicts on the simple names Document, Field, JSONException, and JSONObject.

        Attachments

          Activity

            People

            • Assignee:
              hugo.huijser Hugo Huijser
              Reporter:
              peter.shin Peter Shin
              Recent user:
              Lester Pi
              Participants of an Issue:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package
                7.0.X
                Master