Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-79657

gulp theme build script does not correctly expand liferay-hook.xml language property settings

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 7.0.X, Master
    • Fix Version/s: 7.0.X, 7.1.X, Master
    • Component/s: Liferay Themes
    • Labels:
      None

      Description

      In a liferay-hook.xml file it should be possible to reference language property files with wildcards:

      <?xml version="1.0"?>
      <!DOCTYPE hook PUBLIC "-//Liferay//DTD Hook 7.0.0//EN" "http://www.liferay.com/dtd/liferay-hook_7_0_0.dtd">
      
      <hook>
      	<language-properties>content/Language*.properties</language-properties>
      </hook>
      

      The build scripts are designed to resolve widcards and substitute the liferay-hook.xml with an expanded version.

      Steps to reproduce

      1. Create a theme with language keys and a liferay-hook.xml which references the language property files with a wildcard
        • Language keys go in {THEME_ROOT}/src/WEB-INF/src/content
        • liferay-hook.xml goes in {THEME_ROOT}/src/WEB-INF
      2. Build the theme with gulp deploy
      3. Check the generated liferay-hook file in this path: build/WEB-INF/liferay-hook.xml

      Expected Result:

      build/WEB-INF/liferay-hook.xml should contain a list of all language property files that exist according to the wildcard path

      Actual result:

      build/WEB-INF/liferay-hook.xml has the same content as src/WEB-INF/liferay-hook.xml, and creates an empty liferay-hook.xml.processed

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              alfred.sampang Alfred Sampang
              Reporter:
              allen.ziegenfus Allen Ziegenfus
              Participants of an Issue:
              Recent user:
              Alfred Sampang
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                2 years, 6 weeks, 1 day ago

                  Packages

                  Version Package
                  7.0.X
                  7.1.X
                  Master