Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-79775

portlet:renderURL copyCurrentRenderParameters default value is true

Details

    Description

      description

      In portlet specification 2.0, page 225 (Portlet Tag Library->renderURL) there is:

      copyCurrentRenderParameters ... The default for this attribute is false.

       

      However, in ParamAndPropertyAncestorTagImpl it is set to true.

      I checked the behaviour in a <portlet:requestURL> tag, and it is definitely set to true by default.

      hint

      The commit which sets copyCurrentRenderParameters to true is 

      https://github.com/brianchandotcom/liferay-portal/pull/31993/commits/43a653d7c20aa60c1444c302150a0efd8b9ef970

      and the commit message is:

      LPS-59311 Set attribute copyCurrentRenderParameters to false.

      Addinfo to Pluto:
      PortletURLTag286.java, line 99:

         public Boolean isCopyCurrentRenderParameters() {
             return new Boolean(copyCurrentRenderParameters);
         }
      

      and copyCurrentRenderParameter's default value is null, which will be false with new Boolean()
      https://github.com/apache/portals-pluto/blob/2ed0fb753d7fb936eb421801a22393be73d1a532/pluto-taglib/src/main/java/org/apache/pluto/tags/PortletURLTag286.java#L99
       

      Attachments

        Issue Links

          Activity

            People

              neil.griffin Neil Griffin
              peter.borkuti Peter Borkuti (Inactive)
              Kiyoshi Lee Kiyoshi Lee
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                4 years, 32 weeks, 5 days ago

                Packages

                  Version Package