-
Type:
Bug
-
Status: Closed
-
Resolution: Fixed
-
Affects Version/s: Master
-
Fix Version/s: 7.0.0 DXP FP49, 7.0.0 DXP SP8, 7.0.X, 7.1.0 Beta 2, 7.1.X, Master
-
Component/s: JS Toolkit, ~ [Archived] Frontend Infrastructure
-
Branch Version/s:7.0.x
-
Backported to Branch:Committed
-
Fix Priority:4
-
Git Pull Request:
When deploying a bundle containing npm packages with one or more modules that have any dependency which names contains the string "function", like for example:
Liferay.Loader.define( 'my-package@1.0.0/index', ['module', 'exports', 'require', './_a-function', './_is-object'], function() { console.log('Hi there'); } );
The FlatNPMBundleProcessor gets fooled and stops parsing the dependencies at that point. So, in the above example, the processor would not detect the './is-object' dependency.
Steps to reproduce:
- Start portal
- Deploy attached OSGi bundle
- Open a browser and request "http://localhost:8080/o/js_loader_modules"
- Look for "
LPS-81374@1.0.0/index" (it may appear more than once) until the following is found:
Expected results:
- Make sure that all "./_a-function", "./_is-object", and "./_invoke" dependencies appear (not just "module", "exports", and "require")
Actual results:
- Only "module", "exports", and "require" appear.