DeviceServicePreAction references are not removed from portal.properties

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 7.0.0 DXP FP59, 7.0.0 DXP SP9, 7.0.X, 7.1.10 DXP FP1, 7.1.1 CE GA2, 7.1.10.1 SP1, 7.1.X, Master
• Component/s: Core Infrastructure
• Labels:
  • ee-ts
  • liferay-dxp-70-sp9
  • liferay-dxp-71-sp1
  • liferay-fixpack-de-59-7010
  • liferay-fixpack-dxp-1-7110
• Branch Version/s:
  7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Story Points: 0.25
• Fix Priority: 2
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/61615

Background
LPS-57398 moved com.liferay.portal.events.DeviceServicePreAction as MobileDeviceServicePreAction (renamed to MDRServicePreAction  within LPS-57869) to osgi module under package com.liferay.mobile.device.rules.events

Class com.liferay.mobile.device.rules.events.MDRServicePreAction is defined as a service pre-action, which runs automatically without setting it in the portal.properties. 

Problem
The problem is that references to the old classname were not deleted within LPS-57398 and DXP source still contains DeviceServicePreAction references under the servlet.service.events.pre property.

    servlet.service.events.pre=com.liferay.portal.events.ServicePreAction,com.liferay.portal.events.ThemeServicePreAction
    #servlet.service.events.pre=com.liferay.portal.events.LogMemoryUsageAction,com.liferay.portal.events.LogThreadCountAction,com.liferay.portal.events.ServicePreAction,com.liferay.portal.events.DeviceServicePreAction,com.liferay.portal.events.ThemeServicePreAction
    #servlet.service.events.pre=com.liferay.portal.events.LogSessionIdAction,com.liferay.portal.events.ServicePreAction,com.liferay.portal.events.DeviceServicePreAction,com.liferay.portal.events.ThemeServicePreAction
    #servlet.service.events.pre=com.liferay.portal.events.ServicePreAction,com.liferay.portal.events.DeviceServicePreAction,com.liferay.portal.events.ThemeServicePreAction,com.liferay.portal.events.RandomLayoutAction
    #servlet.service.events.pre=com.liferay.portal.events.ServicePreAction,com.liferay.portal.events.DeviceServicePreAction,com.liferay.portal.events.ThemeServicePreAction,com.liferay.portal.events.RandomLookAndFeelAction
    #servlet.service.events.pre=com.liferay.portal.events.ServicePreAction,com.liferay.portal.events.DeviceServicePreAction,com.liferay.portal.events.ThemeServicePreAction,com.liferay.portal.events.SecureRequestAction
    servlet.service.events.pre.error.page=/common/error.jsp
    servlet.service.events.post=com.liferay.portal.events.ServicePostAction

Effect
Containing those lines is misleading and using com.liferay.portal.events.DeviceServicePreAction causes ClassNotFoundException:

Unable to load com.liferay.portal.events.DeviceServicePreAction with the portal class loader or the current context class loader
 java.lang.ClassNotFoundException: com.liferay.portal.events.DeviceServicePreAction