Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-83889

Avoid using == to compare strings in PortletConfigurationIconTracker

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Won't Fix
    • Affects Version/s: 7.0.X, 7.1.X, Master
    • Fix Version/s: None
    • Component/s: Performance
    • Labels:
      None

      Description

      We're using == to compare a String in PortletConfigurationIconTracker

      PortletRequestWrapper portletRequestWrapper =
                  new PortletRequestWrapper(portletRequest) {
      
                      @Override
                      public Object getAttribute(String name) {
                          if (name == WebKeys.THEME_DISPLAY) {
                              return themeDisplay;
                          }
      
                          return super.getAttribute(name);
                      }
      
                  };
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since last comment:
                  1 year, 15 weeks, 4 days ago

                  Packages

                  Version Package