Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-86029

Velocity Tag Impl does not buffer input for inline JSP writing

Details

    Description

      Description
      When using a velocity based theme the portlet configuration options are not written inside of an unordered list and appear on the same level in the html as the 3 dots options button. This is caused by VelocityTaglibImpl using PipingPageContext to set up the Tag Support. Piping page context however does not replace the writer on each push body as does PipingContextWrapper which allows for JSP pages to be written inline and buffer the input to be written at the appropriate time on the page.

      Steps to Reproduce

      1. Deploy the attached theme
      2. Configure a page to use the classic-local theme
      3. Go to the page and hover the mouse on a portlet top border

      Expected Results
      The portlet configuration options will be hidden until the 3 dots button is clicked

      Actual Results
      The configuration options are listed above the 3 dot options button.

      Reproduced on
      7.0.x - 468aae1851906258a7b69f2c4fa1f753784bf935
      Master - Could no reproduce on master because I could not get a velocity theme to deploy, however the underlying code is exactly the same between master and 7.0.x.

      Attachments

        Activity

          People

            joyce.wang Joyce Wang
            samuel.ziemer Sam Ziemer
            Kiyoshi Lee Kiyoshi Lee
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              4 years, 8 weeks, 5 days ago

              Packages

                Version Package
                7.0.0 DXP FP60
                7.0.0 DXP SP9
                7.0.X
                7.1.10 DXP FP3
                7.1.1 CE GA2
                7.1.10.1 SP1
                7.1.X
                Master