Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-86764

Useless upgrade processes run during the initial database creation

Description

    Steps to reproduce it:

    1. Startup master with a fresh database

    Results:
    Some upgrade processes run, for example:

    2018-10-29 09:26:18.469 INFO  [main][UpgradeProcess:107] Completed upgrade process com.liferay.microblogs.web.internal.upgrade.v1_0_0.UpgradePortletId in 13 ms
    INFO - Completed upgrade process com.liferay.microblogs.web.internal.upgrade.v1_0_0.UpgradePortletId in 13 ms
    2018-10-29 09:26:18.799 INFO  [main][UpgradeProcess:93] Upgrading com.liferay.push.notifications.web.internal.upgrade.v1_0_0.UpgradePortletId
    INFO - Upgrading com.liferay.push.notifications.web.internal.upgrade.v1_0_0.UpgradePortletId
    

    And others that don't print traces such the one related to _configurationUpgradeStepFactory in RSSWebUpgrade are executed when it's not needed.

    Expected results:
    Those upgrade process are not executed.

    Technical notes:
    For web modules, we need to specify the upgrade path for clean installations, that upgrade path has to run from 0.0.0 to the latest defined schema version, however we usually forget to update it. Just check the previous examples.

    To solve it we should either:

    1. Review all web upgrade processes and create a SF rule to avoid future mistakes or
    2. Create a framework to avoid to have to update that upgrade path anytime (preferred)

    Attachments

      Issue Links

        Activity

          People

            lucas.falcao Lucas Falcao
            alberto.chaparro Alberto Chaparro
            Brian Wulbern Brian Wulbern
            Kevin Lee Kevin Lee
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              39 weeks, 1 day ago

              Packages

                Version Package
                7.4.13 DXP GA1
                7.4.3.4 CE GA4
                7.4.3.40 CE GA40
                7.4.3.41 CE GA41
                7.4.3.42 CE GA42
                Master