Avoid to execute DB Upgrade tool between two GAs for the same Liferay version

• Type: Story
• Status: Closed
• Priority: Minor
• Resolution: Completed
• Affects Version/s: 7.2.X, Master
• Fix Version/s: 7.2.X, 7.2.1 CE GA2, Master
• Component/s: Core Infrastructure > Upgrade Framework
• Labels:
  • QA-AUTOMATION
  • liferay-dxp-72-sp1
  • liferay-fixpack-dxp-2-7210
  • pt-upgrade-review
• Branch Version/s:
  7.2.x
• Backported to Branch:
  Committed
• Epic/Theme:
  • Upgrade-Improvements
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/74540

Steps to reproduce it:

1. Startup 7.2 GA1
2. Shutdown it
3. Startup 7.2 GA2 (current master)

Expected results:
When there is no upgrades to run we shouldn't ask for using the DB Upgrade Tool

Results:
You will get something like this:

Starting Liferay Community Edition Portal 7.1.0 CE GA2 (Judson / Build 7101 / October 30, 2018)
2018-11-05 17:22:35.025 INFO  [main][StartupHelper:72] There are no patches installed
You must first upgrade to Liferay Portal 7101
2018-11-05 17:22:35.098 ERROR [main][MainServlet:277] java.lang.RuntimeException: You must first upgrade to Liferay Portal 7101
java.lang.RuntimeException: You must first upgrade to Liferay Portal 7101
        at com.liferay.portal.tools.DBUpgrader.checkRequiredBuildNumber(DBUpgrader.java:90)
        at com.liferay.portal.events.StartupAction.doRun(StartupAction.java:150)
        at com.liferay.portal.events.StartupAction.run(StartupAction.java:78)
        at com.liferay.portal.servlet.MainServlet.processStartupEvents(MainServlet.java:1297)
        at com.liferay.portal.servlet.MainServlet.init(MainServlet.java:274)
        at javax.servlet.GenericServlet.init(GenericServlet.java:158)
        at org.apache.catalina.core.StandardWrapper.initServlet(StandardWrapper.java:1124)
        at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1079)
        at org.apache.catalina.core.StandardWrapper.load(StandardWrapper.java:971)
        at org.apache.catalina.core.StandardContext.loadOnStartup(StandardContext.java:4829)
        at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5143)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
        at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:742)
        at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:718)
        at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:703)
        at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:630)
        at org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1840)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
        at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:112)
        at org.apache.catalina.startup.HostConfig.deployDescriptors(HostConfig.java:525)
        at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:424)
        at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1585)
        at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:308)
        at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
        at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
        at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
        at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:966)
        at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:839)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
        at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1427)
        at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1417)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
        at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
        at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:943)
        at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:258)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
        at org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
        at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:770)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
        at org.apache.catalina.startup.Catalina.start(Catalina.java:682)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
        at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)
Stopping the server due to unexpected startup errors