Page template propagation adds unexpected ServiceContext attributes

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, 7.1.X, Master
• Fix Version/s: 7.0.0 DXP FP64, 7.0.X, 7.1.10 DXP FP5, 7.1.10.1 SP1, 7.1.2 CE GA3, 7.1.X, Master
• Component/s: WCM
• Labels:
  • QA-AUTOMATION
  • ee-ts
  • liferay-dxp-70-sp10
  • liferay-dxp-71-sp1
  • liferay-fixpack-de-64-7010
  • liferay-fixpack-dxp-5-7110
• Branch Version/s:
  7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/65171

Page template propagation is triggered even on getLayout() calls. Since propagation adds layoutPrototypeLinkEnabled and layoutPrototypeUuid attributes to the ServiceContext, every following Layout action will read and use them as a template, even when it's not needed.

There are multiple errors caused by this behavior, this is one of them:

Steps to reproduce:

1. Start the latest master
2. Create a new Site
3. Activate Local Staging with Page Versioning enabled on Public Pages
4. Create a new Test Collection, and a new Page Template in it
   (Change the layout type of the template before you save it)
5. Create a new Public Page using the Page Template
6. Go to that page's configuration
7. Turn off 'Inherit changes', save

Expected behavior: Propagation is switched off

Actual behavior: Propagation is still turned on, not able to disable it

 master @ commit (730b7d8715e539754085b808a0c56e3cd156e672) reproduced