Certain ResourceBundle cannot be clearly overriden

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, 7.1.X, Master
• Fix Version/s: 7.0.10.13 DXP SP13, 7.0.X, 7.1.10 DXP FP5, 7.1.10.1 SP1, 7.1.2 CE GA3, 7.1.X, 7.3.0 CE GA1, 7.3.10 DXP GA1, Master
• Component/s: Portal Services > Localization
• Labels:
  • ee-ts
  • liferay-dxp-70-sp13
  • liferay-dxp-71-sp1
  • liferay-fixpack-de-90-7010
  • liferay-fixpack-dxp-5-7110
• Branch Version/s:
  7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Story Points: 0.25
• Fix Priority: 4
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/65330

Due to com.liferay.lang.merger plugin we do copy Language*.properties file from the language module to the module that requires them. For example it happens with com.liferay.staging.processes.web and com.liferay.staging.lang modules.

So that when a com.liferay.staging.lang key needs to be overriden often the user interprets that they need to override the ResourceBundleLoader from that module, but that doesn't always work if we're employing the key from the com.liferay.staging.processes.web using the calling class (or classloader) to retrieve the ResourceBundleLoader. We should not couple the module key overwrite to our build process.

 

Steps to Reproduce:

1. Use https://dev.liferay.com/en/develop/tutorials/-/knowledge_base/7-0/overriding-language-keys to override the publish-templates key. As bundle.symbolic.name use com.liferay.staging.lang where the key is in the source code.
2. Deploy the created module.

 

Expected Results:

The key should be overridden in the staging publishing page.

 

Actual Results:

The key isn't overridden.

 

The actual way to override the keys isn't very intuitive, and it requires that if a common key needs to be overriden it must be done for every module explicitly.