BooleanFilter toString produces incorrect string

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.0 DXP FP63, 7.0.X, 7.1.10 DXP GA1, 7.1.10 DXP FP3, 7.1.1 CE GA2, 7.1.X, Master
• Fix Version/s: 7.0.0 DXP FP68, 7.0.X, 7.1.10 DXP FP5, 7.1.10.1 SP1, 7.1.2 CE GA3, 7.1.X, Master
• Component/s: Search Infrastructure
• Labels:
  • liferay-dxp-70-sp10
  • liferay-dxp-71-sp1
  • liferay-fixpack-de-68-7010
  • liferay-fixpack-dxp-5-7110
• Branch Version/s:
  7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Sprint: Search | S02 Sprint 7, Search | S02 Sprint 8
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/65551

1. Start portal and go to the Script console in the Server Admin
2. Execute the following Groovy-script:

   import com.liferay.portal.kernel.search.filter.BooleanFilter;
   
   BooleanFilter queryBooleanFilter = new BooleanFilter();
   
   queryBooleanFilter.addRequiredTerm("field", "value");
   
   out.println(queryBooleanFilter)
   

Expected Result:

{MUST({MUST({(field=value), (cached=null, executionOption=null)})}, ), MUST_NOT(), SHOULD(), (cached=null, executionOption=null)}

Actual Results

{MUST({MUST({(field=value), (cached=null, executionOption=null)})}, ), MUST_NOT({MUST({(field=value), (cached=null, executionOption=null)})}, ), SHOULD({MUST({(field=value), (cached=null, executionOption=null)})}, ), (cached=null, executionOption=null)}

The sample code demonstrates that we set a "required term" which qualifies as a MUST clause, though it's also re-used when generating the output string for the MUST_NOT and SHOULD clauses too.