LocalizationUtil Method for returning portlet preference values does not respect defaultValue parameter

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, 7.1.X, Master
• Fix Version/s: 7.0.0 DXP FP70, 7.0.X, 7.1.10 DXP FP6, 7.1.10.2 SP2, 7.1.3 CE GA4, 7.1.X, Master
• Component/s: Portal Services > Localization
• Labels:
  • ee-ts
  • liferay-dxp-70-sp10
  • liferay-dxp-71-sp2
  • liferay-fixpack-de-70-7010
  • liferay-fixpack-dxp-6-7110
• Branch Version/s:
  7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Story Points: 0.25
• Fix Priority: 3
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/66028
• Bug Type: Localization

Description

The order of the parameters called is not correct within the configuration values from the method: 

LocalizationUtil.getLocalizationXmlFromPreferences

On 6.2, this method would return the value passed in the parameter defaultValue if the portlet preferences were empty. In 7.0, 7.1, and master, the method now gives back the string "null", leading to incorrect text being displayed (see screenshot).

Steps to Reproduce

1) Navigate to Control Panel > Configuration > Server Administration
2) Click Script, and enter the following groovy script into the console:

defaultValue =  com.liferay.portal.kernel.util.LocalizationUtil.getLocalizationXmlFromPreferences(preferences, actionRequest, "test", "testvalue");
out.println(defaultValue);

Results of Testing

Expected Behavior: Script returns the value "testValue"
Actual Behavior: Script returns "null." Order of parameters is not correct, as defaultValue is passed into the wrong parameter.

Master

Reproduced.
77c92453dc0c04de0013e1ca1e996fdd358d686f

Branch

Reproduced.
487ddea1c24b1e464975e869387094b999215ec5