Early detection of runtime circular dependencies at compile time in Search unit tests

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Completed
• Affects Version/s: None
• Fix Version/s: 7.2.0 GA1
• Component/s: Search Infrastructure > Framework
• Labels:
  • search-jan19
• Epic Link: Search capabilities in 7.2
• Sprint: Search | S02 Sprint 10
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/66810

The number of components in Search modules is increasing, and with them the risk of runtime errors due to inadvertent cycles. Modify unit tests and fixtures making use of complex dependency graphs, and enforce that instantiation and injection is performed with local variables only (before any fields are assigned) so that circular dependencies become compile errors if any arise.