Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-89369

The npmRunBuild task should fail when there are Soy compile errors

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Completed
    • Affects Version/s: None
    • Fix Version/s: Master
    • Labels:
      None

      Description

      1. Update package.json (remove com.liferay.frontend.js.web from soyDep)
      2. gw :apps:flags:flags-taglib:npmRunBuild --no-rebuild --rerun-tasks
      3. The npmRunBuild task should catch the Soy compile error and fail

      P:\project\lfm\portal\gradlew :apps:flags:flags-taglib:npmRunBuild --no-rebuild --rerun-tasks
      Configuration on demand is an incubating feature.
      > Task :downloadNode SKIPPED
      > Task :apps:flags:flags-taglib:downloadNode SKIPPED
      > Task :apps:flags:flags-taglib:npmInstall
      > Task :apps:flags:flags-taglib:expandJSCompileDependencyComliferayfrontendjsweb300
      > Task :apps:flags:flags-taglib:expandJSCompileDependencies
      
      > flags-taglib@4.0.0 build P:\project\lfm\portal\modules\apps\flags\flags-taglib
      > metalsoy --soyDeps "node_modules/+(clay-button|clay-icon)/**/*.soy" && cross-env NODE_ENV=production babel --source-maps -d classes/META-INF/resources src/main/resources/META-INF/resources && liferay-npm-bundler && npm run cleanSoy
      
      Compiling soy
      Error in plugin 'metal-tools-soy'
      Message:
          Compile error:
      errors during Soy compilation
      src\main\resources\META-INF\resources\flags\Flags.soy:131: error: Undefined template 'liferay.frontend.Modal.render'.
              {call liferay.frontend.Modal.render}
       ^
      1 error
      
      
      Finished compiling soy
      src\main\resources\META-INF\resources\flags\Flags.es.js -> classes\META-INF\resources\flags\Flags.es.js
      Bundling 16 dependencies...
      Bundling took 642ms
      
      > flags-taglib@4.0.0 cleanSoy P:\project\lfm\portal\modules\apps\flags\flags-taglib
      > rimraf src/**/*.soy.js
      
      > Task :apps:flags:flags-taglib:npmRunBuild
      
      BUILD SUCCESSFUL in 15s
      3 actionable tasks: 3 executed
      

        Attachments

          Activity

            People

            • Assignee:
              peter.shin Peter Shin
              Reporter:
              peter.shin Peter Shin
              Recent user:
              Lester Pi
              Participants of an Issue:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package
                Master