Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-89615

Minifier is trying to minify already minified files

    Details

      Description

      This case can be reproduced as per the following:

      1. Create an MVC portlet that calls a .min.css and a .min.js file into the jsp header and footer. Target the footer with the css and add a few console log lines to the js. Neither the css nor the js should be actually minified, just rename the file.
      "com.liferay.portlet.footer-portlet-javascript=/js/main.min.js",
      "com.liferay.portlet.header-portlet-css=/css/main.min.css",
      1. Start DXP
      2. Deploy created MVC portlet
      3. Added the portlet to the Welcome page
      4. Open developer tools, you can see the console log in console, access the js file
        In sources you can access the css.

      Actual behaviour: ComboServlet.java remininifies the css and js file

      Expected behaviour: ComboServlet.java should not reminify .min.js and .min.css files

       

      Note:

      I add a sample portlet, that contains a non minified main.min.css and a non minified main.min.js file.

      This seemed to be the easiest way to reproduce and test the issue, without debugging ComboServlet.js

      If the js and css is minified after deployment, the issue is reproduced. If the js and css file is not minified after deployment, the issue is solved. Please note that the content of css is still merged together with other minified css files, just check if the content of the css is added as minified or not. 

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              joyce.wang Joyce Wang
              Reporter:
              norbert.nemeth Norbert Németh
              Participants of an Issue:
              Recent user:
              Enterprise Release HU
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                1 year, 37 weeks ago

                  Packages

                  Version Package
                  7.0.0 DXP FP79
                  7.0.10.11 DXP SP11
                  7.0.X
                  7.1.10 DXP FP10
                  7.1.10.2 SP2
                  7.1.3 CE GA4
                  7.1.X
                  Master