Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-90102

Segments editor breaks due to javascript minification

    Details

      Description

       

      Steps to Reproduce:

      1. Go to Members/People > Segments
      2. Click  to a new Segment

       Expected behavior: the criteria editor shows and you can define the segment criteria

       Current behavior: the criteria editor does not show. The JS console shows parser errors (see attached screenshot)

       

      Additional Notes:

      It only happens when `javascript.fast.load` is set to `true`

      It is happening in the JS combo file. And it seems to be produced by Java, not by the bundler.

      The error is a misbehaviour in the way the different files are put together into the combo. It skips a break line when joining `react.production.min.js` with a file that loads `ReactPropTypesSecret`, and when joining `react-is.production.min.js` with `react-is.development.js`.

      We found out that already minimized files are now skipped, but a line break must still be added when combining them in the combo servlet.

       

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              joyce.wang Joyce Wang
              Reporter:
              angelo.youn Angelo Youn (Inactive)
              Participants of an Issue:
              Recent user:
              Brian Wulbern
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                1 year, 38 weeks ago

                  Packages

                  Version Package
                  7.0.0 DXP FP79
                  7.0.10.11 DXP SP11
                  7.0.X
                  7.1.10 DXP FP10
                  7.1.10.2 SP2
                  7.1.3 CE GA4
                  7.1.X
                  Master