Upgrading Web Content with Display Pages fails because of plid

• Type: Regression Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: Master
• Component/s: ~[Archived] WCM
• Labels:
  • ee-ts
  • upgrades
• Story Points: 1
• Fix Priority: 3
• Last Working Version:
  7.1.X

Description

Upgrading from 7.0.x to master with Web Content with Display Pages fails. Because when AssetDisplayPageService._getPlid() is called but no assetRendererFactory is returned, failing the upgrade.

Steps to Reproduce

1. In a 7.0.x bundle, add an Asset Publisher to a page
2. Configure the Asset Publisher under Display Settings > Set and Enable set the Asset Publisher as the Default Asset Publisher for this Page
3. Create a Web Content and set the display page as the previous step's page
4. Save the Web Content
5. Shutdown the portal and upgrade to master using the tools/portal-tools-db-upgrade-client/db_upgrade in the bundle.

Expected Results: No errors.
Actual Result: The upgrade fails with the following error.

 ERROR [ForkJoinPool-1-worker-1][UpgradeAssetDisplayPageEntry:162] Unable to add asset display page entry for article 30752
java.lang.NullPointerException
	at com.liferay.asset.display.page.service.impl.AssetDisplayPageEntryLocalServiceImpl._getPlid(AssetDisplayPageEntryLocalServiceImpl.java:167)
	at com.liferay.asset.display.page.service.impl.AssetDisplayPageEntryLocalServiceImpl.addAssetDisplayPageEntry(AssetDisplayPageEntryLocalServiceImpl.java:75)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.portal.spring.aop.AopMethodInvocation.proceed(AopMethodInvocation.java:44)
	at com.liferay.portal.spring.transaction.TransactionInterceptor.lambda$invoke$0(TransactionInterceptor.java:61)
	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor._execute(DefaultTransactionExecutor.java:128)
	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:51)
	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:59)
	at com.liferay.portal.spring.aop.AopMethodInvocation.proceed(AopMethodInvocation.java:51)
	at com.liferay.portal.service.ServiceContextAdvice.invoke(ServiceContextAdvice.java:46)
	at com.liferay.portal.spring.aop.AopMethodInvocation.proceed(AopMethodInvocation.java:51)
	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:44)
	at com.sun.proxy.$Proxy607.addAssetDisplayPageEntry(Unknown Source)
	at com.liferay.journal.internal.upgrade.v1_1_6.UpgradeAssetDisplayPageEntry$SaveAssetDisplayPageEntryCallable.call(UpgradeAssetDisplayPageEntry.java:157)
	at com.liferay.journal.internal.upgrade.v1_1_6.UpgradeAssetDisplayPageEntry$SaveAssetDisplayPageEntryCallable.call(UpgradeAssetDisplayPageEntry.java:138)
	at java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1424)
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)