Service Builder adds columns with db-column name as badColumnNames even if db-name is valid

• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 7.0.0 DXP FP78, 7.0.10.11 DXP SP11, 7.0.X, 7.1.10 DXP FP10, 7.1.10.2 SP2, 7.1.3 CE GA4, 7.1.X, 7.2.X, Master
• Component/s: Core Infrastructure > Service Builder
• Labels:
  • liferay-dxp-70-sp11
  • liferay-dxp-71-sp2
  • liferay-fixpack-de-78-7010
  • liferay-fixpack-dxp-10-7110
  • pt-app-security-review
• Branch Version/s:
  7.2.x, 7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/69536

Steps to reproduce:

1. Follow the steps to create a new model entity with service builder
2. In the service.xml, add at least one column with a db-name argument, to force the db name to be different from the entity field name in the code. Use a valid column name.
3. Run buildService with the latest service builder plugin
4. Open the <EntityName>PersistenceImpl.java autogenerated class and scroll down to the bottom to find the _badColumnNames variable

Expected behaviour: the _badColumnNames variable contains only actual bad column names, defined in the bad_column_names.txt file of the Service Builder (e.g. uuid)

Current behaviour: the _badColumnNames contains the name of the column with the db-name attribute, even though it is correct.

 

This issue causes the autogenerated <EntityName>PersistenceImplTest.findAll tests fail.