Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-92018

Update portal properties to reflect maxActive change to maxTotal for Tomcat database pool connection handling for Tomcat 7.0 to Tomcat 8.0 version change

    Details

      Description

      Description

      As part of the Tomcat 7.0 to Tomcat 8.0 version shift maxActive was replaced by maxTotal. Our portal.properties file continues to list maxActive which means that our customers using Tomcat as their connection pool handler are performance tuning with the incorrect property.

      To my current understanding this only impacts customers tell Liferay to use Tomcat as their connection pool handler, such as with jdbc.default.jndi.name=jdbc/LiferayPool

      http://tomcat.apache.org/migration-8.html#Database_Connection_Pooling

      Tomcat 8, as well as Tomcat 7, is shipped with two implementations of a database connection pool. The first implementation (the default one; though technically this can be changed via javax.sql.DataSource.Factory system property) is a copy of Apache Commons DBCP 2.x project, renamed to a different package…

      There are a number of notable changes between Apache Commons DBCP 1.x (used by Tomcat 7 and earlier) and Apache Commons DBCP 2.x which are likely to require configuration changes.
      The maxActive configuration option has been renamed to maxTotal

      Steps to reproduce

      1.Navigate to the Liferay bundle’s directory
      2. Navigate to /liferay_home/tomcat_home/ROOT/WEB-INF/lib/
      3. Open portal-impl.jar
      4. Open portal.properties
      5. Search for “maxActive”

      Results of Testing

       Expected Result: maxTotal should be listed alongside maxActive in some capacity so that customers who use Tomcat as their database connection pool handler are not forced to use the default maxTotal=8 while our default is maxActive=100
       Actual Result: maxActive is listed, which only works for Tomcat 7.0. On bundles running on Tomcat 8.0 the default value is used (maxTotal=8)

      Errors/Logs

      N/A

      Master

      62b4d481d0d29eae24cb8825fb2ee4fdd4f6165e

      Branch

      Reproduced: 47cf167c77aabb3dc15a1e1b5ec4a6357f0274cf

        Attachments

          Activity

            People

            • Assignee:
              william.nealeigh William Nealeigh
              Reporter:
              william.nealeigh William Nealeigh
              Participants of an Issue:
              Recent user:
              William Nealeigh
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                30 weeks, 2 days ago

                Packages

                Version Package