Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-92816

Remove 'Synchronized Search' setting which has no impact on Embedded connection since Elasticsearch 6

    Details

      Description

      We removed the related backend for com.liferay.portal.search.elasticsearch6.configuration.ElasticsearchConfiguration.syncSearch() in https://github.com/liferay/liferay-portal/commit/9c1925fa22a71db4360229026bc3c8269ea06d37 due to ES5 breaking changes:

      • dropped "QUERY_FETCH_ACTION_NAME" constant
      • dropped "removeHandler" method
      • "requestHandlers" field holds an immutable map

      See:
      https://github.com/elastic/elasticsearch/blob/6.0/core/src/main/java/org/elasticsearch/action/search/SearchTransportService.java#L400-L407
      https://github.com/elastic/elasticsearch/blob/6.0/core/src/main/java/org/elasticsearch/transport/TransportService.java#L745-L752

      "Synchronized Search" is still available, though it does nothing so it should be removed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                brian.chan Brian Chan
                Reporter:
                tibor.lipusz Tibor Lipusz
                Participants of an Issue:
                Recent user:
                Tibor Lipusz
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since last comment:
                  21 weeks, 4 days ago

                  Packages

                  Version Package
                  Master