Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-93169

Site Navigation Menu Item layout references are not properly removed if they do not exist in live

    Details

    • Type: Regression Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: Master
    • Fix Version/s: Master
    • Component/s: WCM

      Description

      Description
      If you delete a layout in live and publish a navigation menu (that does not publish any layout updates), we should still check to make sure the navigation menu references exist in the live site. This was reverted here: https://github.com/liferay/liferay-portal/commit/07f874c6c08cec659d2115ef48cd704636dee426#diff-5237256942935140c4cde9511a319b52, but only stopped working recently, so something else likely caused it than the specified commit. (possibly removed previously because it was uneeded after a certain change).

      Steps to Reproduce

      1. Create 3 layouts and activate local live staging
      2. Delete one of the layouts in the live site
      3. In the staging site, create a navigation menu referencing all 3 layouts
      4. Publish to live (only the navigation menu)

      Expected Result
      Navigation menu only tries to publish navigation menu items that have a reference in the live site

      Actual Result
      Navigation menu tries to publish all items, causing a PortletDataException

      2019-04-02 01:01:21.646 ERROR [liferay/background_task-9][BackgroundTaskMessageListener:173] Unable to execute background task
      com.liferay.exportimport.kernel.lar.PortletDataException
              at com.liferay.exportimport.kernel.lar.BaseStagedModelDataHandler.importStagedModel(BaseStagedModelDataHandler.java:433)
              at com.liferay.exportimport.kernel.lar.StagedModelDataHandlerUtil.importStagedModel(StagedModelDataHandlerUtil.java:456)
      

      Tested on Tomcat 9.0.10 + MySQL 5.7
      Portal master GIT ID: dfeea96b35f2700cd1d927190c403c490f36cb3c

        Attachments

          Activity

            People

            • Assignee:
              kyle.miho Kyle Miho
              Reporter:
              kyle.miho Kyle Miho
              Participants of an Issue:
              Recent user:
              Kyle Miho
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                6 weeks, 5 days ago