Site template propagation fails under load with StaleObjectStateException

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, 7.1.X, 7.2.X, Master
• Fix Version/s: 7.0.0 DXP FP86, 7.0.10.12 DXP SP12, 7.0.X, 7.1.10 DXP FP13, 7.1.X, 7.2.10 DXP FP1, 7.2.X, 7.2.1 CE GA2, 7.3.10 DXP GA1, Master
• Component/s: Site Templates
• Labels:
  • ee-bp
  • ee-ts
  • liferay-dxp-70-sp12
  • liferay-fixpack-de-86-7010
  • liferay-fixpack-dxp-1-7210
  • liferay-fixpack-dxp-13-7110
• Branch Version/s:
  7.2.x, 7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 4
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/76556

Reproduction steps:
1. Start a bundle with the latest master version
2. Create a site template named "temp1"
4. Add 5 pages to the template: page1, page2, ... page5.
5. Add some basic portlets to all pages (AP, WCD, Blogs, Wiki, etc.)
6. Create 4 sites from temp1: t1site1, ..., t1site4
7. Open JMeter and start a thread group of 10 threads for these 4 pages ( [^site_template_propagation_01.jmx] ):

• "/web/t1site1/page1"
• "/web/t1site2/page1"
• "/web/t1site3/page1"
• "/web/t1site4/page1"

8. Change one thing (e.g. add an extra portlet) on page1 page of the temp1 template.

Actual behavior: After a few seconds, StaleObjectStateException is thrown for LayoutSet entry (sometimes also unique constraint errors for the Lock table). After a few tries the propagation eventually fails (logs: [^master_staleobject_logs_20190722.txt] ).
Expected behavior: The propagations should finish successfully.

The memory settings I used:

-Xms4g -Xmx4g -XX:MaxNewSize=1536m -XX:MaxMetaspaceSize=768m -XX:MetaspaceSize=768m -XX:NewSize=1536m -XX:SurvivorRatio=7

To see the SitesImpl log messages, set the "com.liferay.portlet.sites.util" log level to DEBUG and "com.liferay.exportimport.internal.controller" to INFO