Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-95837

When configuring Organization Types, having no children type results in a blank entry

    Details

      Description

      When creating a new Organization type, it is possible to specify a type with no possible children types.  However, when doing so, an empty string is saved, and thus later returned when checking for children types.  This results in the OrganizationImpl.isParentable returning true as well as a blank value appearing as a possible child type.  This is loosely intended since validation of children types is done when attempting to save an organization, not when configuring the type.

      Steps to Reproduce:

      1. Go to Control Panel > Configuration > System Settings > Users > Organization Types
      2. Add a new entry with the following values:
        1. Name: Location
        2. (leave the checkboxes as-is)
        3. Children Types: (remove the children types value)
      3. Save the entry
      4. Go to Control Panel > Users > Users and Organizations
      5. On the "Organizations" tab, click the Add button and select "Location"
      6. Fill in any required fields and save the Locations org type.
      7. Go back to the Users and Organizations > Organizations tab
      8. Click on the elipses icon to the right of the newly created Location

      Expected Results: Since the Location org type has no children types, there is no "Add" option for children types

      Actual; Results: The option "Add " exists, since it is not possible to save a completely empty value for the children types, only a blank string.

      Reproduced in master: 5f56505b58ea180df52994f43df877efd9529593

        Attachments

          Activity

            People

            • Assignee:
              sharry.shi Sharry Shi
              Reporter:
              christopher.kian Christopher Kian
              Participants of an Issue:
              Recent user:
              Clarissa Velazquez
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                25 weeks, 6 days ago

                Packages

                Version Package
                7.1.10 DXP FP13
                7.1.X
                Master