Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-97406

Create tickets for removing lint suppressions

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Completed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Sprint:
      S03E03 - Mucugê

      Description

      In LPS-97079 we created a smallish number of lint suppressions — that is, we marked some possible problems in the code as "warnings" rather than "errors" — in order to enable us to turn on linting in CI.

      The full list of modules containing suppressions is here: https://gist.github.com/wincent/0279c6be9340ca398c4d3f9e227ce17e

      And the full list of "errors" that are turned into "warnings" by the suppressions is here: https://gist.github.com/wincent/fa8d1acf9ac44eebacdd9e19930d9df2

      So, we need to create an epic for this and then create basically 1 ticket per module — with a few exceptions noted below — and assign it to the most relevant team with the goal of removing the suppression.

      There are a few exceptions that I think can be grouped together:

      • I'd probably group all the "frontend-image-editor" lints under one ticket.
      • Ditto for "change-tracking"
      • And for "dynamic-data-mapping"
      • Probably "hello-soy" too.
      • And "layout".

      So instead of 35 tickets for 35 modules, we'd wind up with about 18 tickets.

      As an example of what the tickets should/could like, I created one for "frontend-js/frontend-js-web": LPS-97405

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package