Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-97488

Remove unnecessary JSONPackageJSONCheck suppressions

    Details

      Description

      • frontend-js-node-shims had a suppression because it didn't define "checkFormat" and "format" scripts; we didn't define them because there is nothing to check in this module. But still, we can remove the suppression by adding the scripts and specifying empty globs in the npmscripts.config.js file.
      • frontend-js-web had a suppression because it defined "devDependencies", which we only allow at the top level; we can remove them because we have access to this package (and all the webpack-related packages) transitively via the presence of liferay-npm-scripts.

      Also note:

      • segments-web has a suppression because it defines "devDependencies" (which will take us a while to remove), and because it didn't define a "checkFormat" script; I added the latter, even though I can't remove the suppression yet due to the "devDependencies".
      • analytics-client-js is effectively an independent project that happens to live inside this repo, so it will probably have "devDependencies" of its own for the foreseeable future, so I can't remove that one immediately either.

        Attachments

          Activity

            People

            • Assignee:
              brian.chan Brian Chan
              Reporter:
              greg.hurrell Greg Hurrell
              Recent user:
              Csaba Turcsan
              Participants of an Issue:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package
                7.2.X