Details

    • Sprint:
      S03E07- Recife

      Description

       Actions:

      Prior to merging into upstream:

      1. FI informs other product teams of when this update will occur and ask for their feedback on any missing icons when font awesome and glyphicon are removed.
        1. Removal in Classic - https://github.com/john-co/liferay-portal/pull/154
        2. Removal in Admin - https://github.com/john-co/liferay-portal/pull/155

      Development:

      1. Frontend QA to manually inspect select known areas affected by the migration
        • Manual test that icons have been replaced with approved lexicon icons
          • Validate icons are visible on Firefox 60esr, Chrome, IE11, and Edge
          • Test font is readable
          • Test images have good clarity (not blurry, not distracting)
          • Test size of images look proportional
        • Identify other areas in portal that still use font-awesome and glyphicon
      2. Need to update poshi functional test paths with glyphicon removal
        Searching glyphicon
         /home/john-co/Liferay/public/master/portal-web/test/functional/com/liferay/portalweb/paths/pathlib/uisections/Treeview.path
          13,140: 	<td>//div[contains(@class,'treeview-node-main') and @aria-expanded='false']/div[@class='treeview-node-toggler'] | //span[contains(@class,'glyphicon-plus')]</td>
        
        /home/john-co/Liferay/public/master/portal-web/test/functional/com/liferay/portalweb/paths/plugin/contenttargeting/EditCampaign.path
          80,134: 	<td>//div[contains(@class,'${key_trackingAction}trackingaction') and contains(@class,'form-builder')]//button/span[contains(@class,'glyphicon-trash')]</td>
        
        /home/john-co/Liferay/public/master/portal-web/test/functional/com/liferay/portalweb/paths/portlet/dynamicdatamapping/DDMEditStructure.path
          157,182: 	<td>xpath=(//div[contains(@class,'component') and contains(@class,'form-builder-field')]/div/label[contains(.,'${key_fieldFieldLabel}')]/../../div/div/button/span[contains(@class,'glyphicon-trash')]/..)[1]</td>
        
        /home/john-co/Liferay/public/master/portal-web/test/functional/com/liferay/portalweb/paths/portlet/sitepages/SitePages.path
          76,128: 	<td>//div[contains(@id,'selectPortletsTree')]//span[contains(.,'${key_componentName}')]/../span[contains(@class,'tree-hitarea glyphicon-plus')]</td>

      Post merge: 

      1. Create automation test to check icon is visible in high risk areas such as ddm (concentrated area of icons)
      2. Monitor CI, automation for regressions due to leftover glyphicon/font-awesome removal
      3. Monitor escaped bugs not caught by automation/manual testing and adjust maintenance test plan as necessary

        Attachments

          Activity

            People

            Assignee:
            support-lep@liferay.com SE Support
            Reporter:
            john.co John Co
            Recent user:
            Chema Balsas
            Participants of an Issue:
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package